[GitHub] [accumulo] ctubbsii opened a new pull request #1448: Clean up some internal ZooKeeper utilities

[GitBox <gi...@apache.org>]

ctubbsii opened a new pull request #1448: Clean up some internal ZooKeeper utilities
URL: https://github.com/apache/accumulo/pull/1448
 
 
   * Remove IZoo* interfaces, to reduce unnecessary type hierarchy
     complexity
   * Inline many ZooUtil methods that were only used in one place to reduce
     unnecessary call graph complexity
   * Relocate most of remaining ZooUtil methods into ZooReaderWriter (which
     was the only caller of those methods)
   * Simplify constructors for ZooReader{Writer}, ZooSession, and others to
     reduce unnecessary redundant ways of doing the same thing
   * Remove unnecessary ZooKeeperConnectionInfo container object which was
     only needed because of previous unnecessary complexity with ZooSession
     constructors
   * Move a ZooUtil method for getting instanceId from HDFS volumes to the
     VolumeManager and one for getting the lock data to ZooCache (the only
     caller)
   * Fix up ZooLockTest, which was broken upon refactoring due to some
     incorrect assumptions it was making getting an authenticated
     ZooKeeper object via the previous call chain hell (specifically, the
     auth bytes for mini should be "accumulo:secret" and not just "secret")
   * Use more UTF-8 on getBytes calls while troubleshooting aforementioned
     ZooLockTest
   * Remove unnecessary ZooReaderWriter singleton instance (which could
     cause problems if the getInstance method was called multiple times with
     different parameters), because it was only used in ZooLock constructor,
     and it's not created frequently enough to need to be a singleton

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services