You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/28 04:56:08 UTC
[GitHub] [pulsar] HQebupt opened a new pull request, #17313: [refactor][broker]refactor reflection method in loadbalance module
HQebupt opened a new pull request, #17313:
URL: https://github.com/apache/pulsar/pull/17313
### Motivation
There are multiple ways of loading classes with reflection in Pulsar load balance module. And we should have some common code.
### Modifications
- Unify the reflection method in pulsar load balance module.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
If `yes` was chosen, please highlight the changes
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #17313: [refactor][broker]refactor reflection method in loadbalance module
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17313:
URL: https://github.com/apache/pulsar/pull/17313#issuecomment-1229394017
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #17313: [refactor][broker]refactor reflection method in loadbalance module
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #17313:
URL: https://github.com/apache/pulsar/pull/17313#issuecomment-1230498606
@eolivelli Please help add labels and the milestone before merging the PR, we might miss this change from the release note it the PR without the milestone label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #17313: [refactor][broker]refactor reflection method in loadbalance module
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #17313:
URL: https://github.com/apache/pulsar/pull/17313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org