You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/09/14 18:17:44 UTC

[GitHub] [druid] jon-wei commented on a change in pull request #11688: Task reports for parallel task: single phase and sequential mode

jon-wei commented on a change in pull request #11688:
URL: https://github.com/apache/druid/pull/11688#discussion_r708519553



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
##########
@@ -169,6 +173,11 @@
   @MonotonicNonNull
   private volatile TaskToolbox toolbox;
 
+  private IndexTask sequentialIndexTask;
+  private ParallelIndexTaskRunner<SinglePhaseSubTask, PushedSegmentsReport> parallelSinglePhaseRunner;

Review comment:
       I got rid of the references and adjusted things to use `currentSubTaskHolder`

##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
##########
@@ -1415,4 +1432,169 @@ public Response getCompleteSubTaskSpecAttemptHistory(
       }
     }
   }
+
+  private RowIngestionMetersTotals getTotalsFromBuildSegmentsRowStats(Object buildSegmentsRowStats)
+  {
+    if (buildSegmentsRowStats instanceof RowIngestionMetersTotals) {
+      return (RowIngestionMetersTotals) buildSegmentsRowStats;
+    } else if (buildSegmentsRowStats instanceof Map) {

Review comment:
       Added a comment, the first case was just for unit tests




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org