You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/05 00:12:27 UTC

[GitHub] [arrow] westonpace commented on pull request #13613: ARROW-15582: [C++] Add support for registering standard Substrait functions

westonpace commented on PR #13613:
URL: https://github.com/apache/arrow/pull/13613#issuecomment-1205900131

   > General comment on usage of auto with ARROW_ASSIGN_OR_RAISE. There is a mix of auto and variable type through out the PR. Is there any specific reason? I think there was a recent discussion on minimizing usage of auto in certain places where it is hard to deterimine the data type for the readability sake. Is it the case here?
   
   The primary places I use `auto` are `make_unique` and for STL iterators.  Looking through this PR I see there are also a number of places where I kept `auto` because I was just moving or refactoring existing code that was already using `auto`.
   
   That being said, there may be a few places where I used `auto` incorrectly.  I'll take another scan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org