You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 15:32:27 UTC
Re: Review Request 64610: Updated cpplint from upstream.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64610/
-----------------------------------------------------------
(Updated May 14, 2018, 5:32 p.m.)
Review request for mesos, Armand Grillet and Benjamin Bannier.
Repository: mesos
Description
-------
This patch updates the bundled cpplint to upstream 'e8ffd7ce6'. We
also update the patch file to reflect changes; we include the changes
made in '7b1ab032' which where not included in the patch.
Diffs
-----
support/cpplint.patch 1b4d4ee62ccd40523fe9e8d6d476e1ee82e415bf
support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd
Diff: https://reviews.apache.org/r/64610/diff/1/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 64610: Updated cpplint from upstream.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64610/#review203051
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['64610']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64610
Relevant logs:
- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64610/logs/libprocess-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1456): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\buffer.c(3099): warning C4244: 'function': conversion from 'int64_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(499): warning C4244: '=': conversion from 'int64_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(504): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(185): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(230): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(587): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(598): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(654): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(656): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(675): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(755): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(763): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(874): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1456): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evdns.c(3792): warning C4996: 'GetVersion': was declared deprecated [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (12) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\libprocess\src\tests\benchmarks.cpp(566): error C2276: '&': illegal operation on bound member function expression [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
112 Warning(s)
1 Error(s)
Time Elapsed 00:04:44.12
```
- Mesos Reviewbot Windows
On May 14, 2018, 3:32 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64610/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 3:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the bundled cpplint to upstream 'e8ffd7ce6'. We
> also update the patch file to reflect changes; we include the changes
> made in '7b1ab032' which where not included in the patch.
>
>
> Diffs
> -----
>
> support/cpplint.patch 1b4d4ee62ccd40523fe9e8d6d476e1ee82e415bf
> support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd
>
>
> Diff: https://reviews.apache.org/r/64610/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64610: Updated cpplint from upstream.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
> On May 14, 2018, 4:32 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Failed to apply the current review.
> >
> > Failed command: `python.exe .\support\apply-reviews.py -n -r 64610`
> >
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64610
> >
> > Relevant logs:
> >
> > - [apply-review-64610-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64610/logs/apply-review-64610-stdout.log):
> >
> > ```
> > 64610.patch:17: trailing whitespace.
> >
> > 64610.patch:36: trailing whitespace.
> >
> > 64610.patch:43: trailing whitespace.
> >
> > 64610.patch:55: trailing whitespace.
> >
> > 64610.patch:60: trailing whitespace.
> >
> > warning: squelched 7 whitespace errors
> > warning: 12 lines add whitespace errors.
> >
> > *** Please tell me who you are.
> >
> > Run
> >
> > git config --global user.email "you@example.com"
> > git config --global user.name "Your Name"
> >
> > to set your account's default identity.
> > Omit --global to set the identity only in this repository.
> >
> > fatal: unable to auto-detect email address (got 'jenkins@windows-02.(none)')
> > ```
Small error with the bot. Fixed!
- Mesos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64610/#review203038
-----------------------------------------------------------
On May 14, 2018, 3:32 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64610/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 3:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the bundled cpplint to upstream 'e8ffd7ce6'. We
> also update the patch file to reflect changes; we include the changes
> made in '7b1ab032' which where not included in the patch.
>
>
> Diffs
> -----
>
> support/cpplint.patch 1b4d4ee62ccd40523fe9e8d6d476e1ee82e415bf
> support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd
>
>
> Diff: https://reviews.apache.org/r/64610/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64610: Updated cpplint from upstream.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64610/#review203038
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 64610`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64610
Relevant logs:
- [apply-review-64610-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64610/logs/apply-review-64610-stdout.log):
```
64610.patch:17: trailing whitespace.
64610.patch:36: trailing whitespace.
64610.patch:43: trailing whitespace.
64610.patch:55: trailing whitespace.
64610.patch:60: trailing whitespace.
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: unable to auto-detect email address (got 'jenkins@windows-02.(none)')
```
- Mesos Reviewbot Windows
On May 14, 2018, 3:32 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64610/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 3:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the bundled cpplint to upstream 'e8ffd7ce6'. We
> also update the patch file to reflect changes; we include the changes
> made in '7b1ab032' which where not included in the patch.
>
>
> Diffs
> -----
>
> support/cpplint.patch 1b4d4ee62ccd40523fe9e8d6d476e1ee82e415bf
> support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd
>
>
> Diff: https://reviews.apache.org/r/64610/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64610: Updated cpplint from upstream.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64610/#review203078
-----------------------------------------------------------
Patch looks great!
Reviews applied: [64610]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 14, 2018, 3:32 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64610/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 3:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the bundled cpplint to upstream 'e8ffd7ce6'. We
> also update the patch file to reflect changes; we include the changes
> made in '7b1ab032' which where not included in the patch.
>
>
> Diffs
> -----
>
> support/cpplint.patch 1b4d4ee62ccd40523fe9e8d6d476e1ee82e415bf
> support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd
>
>
> Diff: https://reviews.apache.org/r/64610/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64610: Updated cpplint from upstream.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On May 15, 2018, 9:56 a.m., Armand Grillet wrote:
> > support/cpplint.patch
> > Line 7 (original), 8 (patched)
> > <https://reviews.apache.org/r/64610/diff/1/?file=1916267#file1916267line8>
> >
> > ```
> > apache-mesos (r/64610) $ git commit -m "Updated cpplint from upstream."
> > support/cpplint.patch:8: trailing whitespace.
> > +
> > ```
> > Also applies for a dozen other lines in the file.
Patch files usually reserve the first column for markers on whether a line was added or removed (`+` or `-`, respectively). Lines ending in spaces are from context without changes. We usually keep the default-generated format elsewhere, so let's also do that here to simplify future manual comparisons of versions, dropping.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64610/#review203032
-----------------------------------------------------------
On May 14, 2018, 5:32 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64610/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 5:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the bundled cpplint to upstream 'e8ffd7ce6'. We
> also update the patch file to reflect changes; we include the changes
> made in '7b1ab032' which where not included in the patch.
>
>
> Diffs
> -----
>
> support/cpplint.patch 1b4d4ee62ccd40523fe9e8d6d476e1ee82e415bf
> support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd
>
>
> Diff: https://reviews.apache.org/r/64610/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64610: Updated cpplint from upstream.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64610/#review203032
-----------------------------------------------------------
Fix it, then Ship it!
Tested by comparing the result of `cpplint` on `src/master/*.cpp`, the number of errors and wording is slightly different but this is due to changes in cpplint.
support/cpplint.patch
Line 7 (original), 8 (patched)
<https://reviews.apache.org/r/64610/#comment285093>
```
apache-mesos (r/64610) $ git commit -m "Updated cpplint from upstream."
support/cpplint.patch:8: trailing whitespace.
+
```
Also applies for a dozen other lines in the file.
- Armand Grillet
On May 14, 2018, 3:32 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64610/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 3:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the bundled cpplint to upstream 'e8ffd7ce6'. We
> also update the patch file to reflect changes; we include the changes
> made in '7b1ab032' which where not included in the patch.
>
>
> Diffs
> -----
>
> support/cpplint.patch 1b4d4ee62ccd40523fe9e8d6d476e1ee82e415bf
> support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd
>
>
> Diff: https://reviews.apache.org/r/64610/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>