You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@metamodel.apache.org by ka...@apache.org on 2018/06/21 05:51:19 UTC
[28/31] metamodel git commit: HBase improvements - Small refactoring
on loging
HBase improvements - Small refactoring on loging
Project: http://git-wip-us.apache.org/repos/asf/metamodel/repo
Commit: http://git-wip-us.apache.org/repos/asf/metamodel/commit/9f402956
Tree: http://git-wip-us.apache.org/repos/asf/metamodel/tree/9f402956
Diff: http://git-wip-us.apache.org/repos/asf/metamodel/diff/9f402956
Branch: refs/heads/master
Commit: 9f402956cf483b6984cfcd02994aabb253c349bd
Parents: 738a97d
Author: Gerard Dellemann <g....@quadient.com>
Authored: Tue Jun 19 13:12:39 2018 +0200
Committer: Gerard Dellemann <g....@quadient.com>
Committed: Tue Jun 19 13:12:39 2018 +0200
----------------------------------------------------------------------
.../main/java/org/apache/metamodel/hbase/HBaseClient.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/metamodel/blob/9f402956/hbase/src/main/java/org/apache/metamodel/hbase/HBaseClient.java
----------------------------------------------------------------------
diff --git a/hbase/src/main/java/org/apache/metamodel/hbase/HBaseClient.java b/hbase/src/main/java/org/apache/metamodel/hbase/HBaseClient.java
index e73a643..ecf5e4c 100644
--- a/hbase/src/main/java/org/apache/metamodel/hbase/HBaseClient.java
+++ b/hbase/src/main/java/org/apache/metamodel/hbase/HBaseClient.java
@@ -86,11 +86,11 @@ final class HBaseClient {
}
final byte[] value = getValueAsByteArray(values[i]);
// A NULL value, doesn't get inserted in HBase
- // TODO: Do we delete the cell (and therefore the qualifier) if the table get's updated?
+ // TODO: Do we delete the cell (and therefore the qualifier) if the table get's updated by a NULL
+ // value?
if (value == null) {
- logger.warn("The value of column '{}:{}' is null. This insertion is skipped", columns[i]
- .getColumnFamily()
- .toString(), columns[i].getQualifier().toString());
+ logger.info("The value of column '{}' is null. This insertion is skipped", columns[i]
+ .getName());
} else {
put.addColumn(columnFamily, qualifier, value);
}