You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/09 10:32:12 UTC
[GitHub] [arrow-datafusion] xudong963 opened a new pull request, #2860: chore: make cargo clippy happy in nigtly
xudong963 opened a new pull request, #2860:
URL: https://github.com/apache/arrow-datafusion/pull/2860
Make Cargo Clippy happy in nightly mode, making code more elegant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2860: chore: make cargo clippy happy in nigtly
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2860:
URL: https://github.com/apache/arrow-datafusion/pull/2860#issuecomment-1179527521
Thanks @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2860: chore: make cargo clippy happy in nigtly
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2860:
URL: https://github.com/apache/arrow-datafusion/pull/2860#issuecomment-1179524192
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2860](https://codecov.io/gh/apache/arrow-datafusion/pull/2860?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccd37b6) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/a2da7209ed4a0da68010dcd541a25032a040b9e6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2da720) will **increase** coverage by `0.00%`.
> The diff coverage is `63.88%`.
```diff
@@ Coverage Diff @@
## master #2860 +/- ##
=======================================
Coverage 85.24% 85.25%
=======================================
Files 275 275
Lines 49002 49001 -1
=======================================
+ Hits 41773 41775 +2
+ Misses 7229 7226 -3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/2860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/sql/src/utils.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcWwvc3JjL3V0aWxzLnJz) | `51.95% <45.45%> (+0.40%)` | :arrow_up: |
| [datafusion/core/src/execution/memory\_manager.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9leGVjdXRpb24vbWVtb3J5X21hbmFnZXIucnM=) | `69.95% <50.00%> (-0.31%)` | :arrow_down: |
| [datafusion/core/src/datasource/mod.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9kYXRhc291cmNlL21vZC5ycw==) | `93.93% <100.00%> (ø)` | |
| [...e/src/physical\_optimizer/hash\_build\_probe\_order.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9vcHRpbWl6ZXIvaGFzaF9idWlsZF9wcm9iZV9vcmRlci5ycw==) | `89.04% <100.00%> (ø)` | |
| [datafusion/core/src/physical\_plan/sorts/sort.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL3NvcnRzL3NvcnQucnM=) | `93.09% <100.00%> (ø)` | |
| [...atafusion/optimizer/src/subquery\_filter\_to\_join.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3N1YnF1ZXJ5X2ZpbHRlcl90b19qb2luLnJz) | `93.90% <100.00%> (ø)` | |
| [datafusion/physical-expr/src/expressions/case.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9leHByZXNzaW9ucy9jYXNlLnJz) | `92.75% <100.00%> (ø)` | |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `74.50% <0.00%> (+0.19%)` | :arrow_up: |
| [datafusion/expr/src/window\_frame.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy93aW5kb3dfZnJhbWUucnM=) | `93.27% <0.00%> (+0.84%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2860?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2860?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a2da720...ccd37b6](https://codecov.io/gh/apache/arrow-datafusion/pull/2860?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 merged pull request #2860: chore: make cargo clippy happy in nigtly
Posted by GitBox <gi...@apache.org>.
xudong963 merged PR #2860:
URL: https://github.com/apache/arrow-datafusion/pull/2860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org