You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by erikdw <gi...@git.apache.org> on 2015/09/22 01:54:01 UTC
[GitHub] storm pull request: fix bin/storm's inconsistent indentation and i...
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/751
fix bin/storm's inconsistent indentation and if-then styling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/erikdw/storm fix-bin-storm-style
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/751.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #751
----
commit 0a2843a958dd240ebd6312890e634c9bf5f4883b
Author: Erik Weathers <er...@gmail.com>
Date: 2015-09-21T23:52:50Z
fix bin/storm's inconsistent indentation and if-then styling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix bin/storm's inconsistent indentation and i...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/751#issuecomment-145991606
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix bin/storm's inconsistent indentation and i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix bin/storm's inconsistent indentation and i...
Posted by erikdw <gi...@git.apache.org>.
Github user erikdw commented on the pull request:
https://github.com/apache/storm/pull/751#issuecomment-145997708
@HeartSaVioR : thanks for accepting & merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix bin/storm's inconsistent indentation and i...
Posted by erikdw <gi...@git.apache.org>.
Github user erikdw commented on the pull request:
https://github.com/apache/storm/pull/751#issuecomment-142141703
Most of the changes are whitespace only, but [there are a couple of non-whitespace changes](https://github.com/apache/storm/pull/751/files?w=0) which consist of joining 2 lines with a `;` between the `if []` and `then`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix bin/storm's inconsistent indentation and i...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/751#issuecomment-145992723
@erikdw Thanks for making it consistent, I merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---