You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Stephan Bergmann <sb...@redhat.com> on 2015/09/28 11:07:42 UTC
Incompatible change of oslFileError?
> $ svn diff -c1705196 sal/inc/osl/file.h
> Index: sal/inc/osl/file.h
> ===================================================================
> --- sal/inc/osl/file.h (revision 1705195)
> +++ sal/inc/osl/file.h (revision 1705196)
> @@ -132,6 +132,7 @@
> osl_File_E_USERS,
> osl_File_E_OVERFLOW,
> osl_File_E_NOTREADY,
> + osl_File_E_LOCKED,
> osl_File_E_invalidError, /* unmapped error: always last entry in enum! */
> osl_File_E_TIMEDOUT,
> osl_File_E_NETWORK,
Are you sure that this incompatible change is worth it? By placing the
new enumerator somewhere in the middle of the existing enum, you
unnecessarily not only break compatibility with older versions of AOO,
but also with other OOo derivatives.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Incompatible change of oslFileError?
Posted by Jürgen Schmidt <jo...@gmail.com>.
On 28/09/15 11:07, Stephan Bergmann wrote:
>> $ svn diff -c1705196 sal/inc/osl/file.h
>> Index: sal/inc/osl/file.h
>> ===================================================================
>> --- sal/inc/osl/file.h (revision 1705195)
>> +++ sal/inc/osl/file.h (revision 1705196)
>> @@ -132,6 +132,7 @@
>> osl_File_E_USERS,
>> osl_File_E_OVERFLOW,
>> osl_File_E_NOTREADY,
>> + osl_File_E_LOCKED,
>> osl_File_E_invalidError, /* unmapped error: always last
>> entry in enum! */
>> osl_File_E_TIMEDOUT,
>> osl_File_E_NETWORK,
>
> Are you sure that this incompatible change is worth it? By placing the
> new enumerator somewhere in the middle of the existing enum, you
> unnecessarily not only break compatibility with older versions of AOO,
> but also with other OOo derivatives.
>
Stefan is correct, this should be changed and the new enumerator should
be better added to the end.
Juergen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org