[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5669: Core: Expire Snapshots reachability analysis

[GitBox <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #5669:
URL: https://github.com/apache/iceberg/pull/5669#discussion_r962374179


##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -39,13 +39,21 @@
 
 @RunWith(Parameterized.class)
 public class TestRemoveSnapshots extends TableTestBase {
-  @Parameterized.Parameters(name = "formatVersion = {0}")
+  private final boolean incrementalCleanup;
+
+  @Parameterized.Parameters(name = "formatVersion = {0}, incrementalCleanup = {1}")

Review Comment:
   Parameterized the test to make sure both cleanup strategies work for the existing test cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org