You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/06/02 15:58:04 UTC
[GitHub] flink pull request #4060: [FLINK-6837][table]Fix a small error message bug, ...
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4060
[FLINK-6837][table]Fix a small error message bug, And improve some me…
Fix a small error message bug, And improve some message info.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-6837][table]Fix a small error message bug, And improve some message info.")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6837-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4060.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4060
----
commit fbbdb7ae870d1e66d429d281f1a6e6b2d818763c
Author: sunjincheng121 <su...@gmail.com>
Date: 2017-06-02T15:45:35Z
[FLINK-6837][table]Fix a small error message bug, And improve some message info.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4060: [FLINK-6837][table]Fix a test case name error, a s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4060
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4060: [FLINK-6837][table]Fix a small error message bug, And imp...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4060
In this PR. Fix a test case name error, a small error message bug, And change error message from ` "xxx" + variable` to `s"xxx: '${variable}'`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4060: [FLINK-6837][table]Fix a test case name error, a small er...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4060
The error in Travias CI seems not be relative to this PR, it is filed in https://issues.apache.org/jira/browse/FLINK-6836. So I will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4060: [FLINK-6837][table]Fix a test case name error, a s...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4060#discussion_r119918897
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/OverWindowITCase.scala ---
@@ -147,7 +147,7 @@ class OverWindowITCase extends StreamingWithStateTestBase {
}
@Test
- def testProcTimeBoundedPartitionedRangeOver(): Unit = {
+ def testProcTimeBoundedPartitionedRowsOver(): Unit = {
--- End diff --
Sure. Thanks for the reviewing. @zentol
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4060: [FLINK-6837][table]Fix a test case name error, a s...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4060#discussion_r120000960
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/OverWindowITCase.scala ---
@@ -147,7 +147,7 @@ class OverWindowITCase extends StreamingWithStateTestBase {
}
@Test
- def testProcTimeBoundedPartitionedRangeOver(): Unit = {
+ def testProcTimeBoundedPartitionedRowsOver(): Unit = {
--- End diff --
+1 to this change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4060: [FLINK-6837][table]Fix a small error message bug, ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4060#discussion_r119916283
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/OverWindowITCase.scala ---
@@ -147,7 +147,7 @@ class OverWindowITCase extends StreamingWithStateTestBase {
}
@Test
- def testProcTimeBoundedPartitionedRangeOver(): Unit = {
+ def testProcTimeBoundedPartitionedRowsOver(): Unit = {
--- End diff --
Someone else will have to verify this change, but the other changes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---