You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mynewt.apache.org by Mario TESI <ma...@st.com> on 2019/04/12 15:20:56 UTC
lps33hw sensor driver
Hi All,
I was trying to figure out how to organize the work to add support to MyNewT for the new MEMS sensors produced
by STMicroelectronics and I came across the lps33hw driver (hw / driver / sensors / lps33hw) which actually also supports
the part number LPS22HB, in fact both devices have
- the same Who am I
- same functionalities
- same register map and bitmap
these devices differ only by the case type because LPS33HW is for water proof application while LPS22HB is for generic
usage.
Would it be possible to indicate in the documentation that the lps33hw driver into the distro supports both LPS33HW and
LPS22HB devices (?)
Best Regards,
Mario
Re: lps33thw sensor driver
Posted by Vipul Rahane <vr...@gmail.com>.
I agree with Amr Bekhit. The driver can remain the same but we do want
people to know that different parts are supported using that driver and
hence the keywords fields.
On Thu, May 2, 2019 at 5:00 AM Amr Bekhit <am...@gmail.com> wrote:
> Just a suggestion, in the pkg.yml file for the lps33hw package. you'll
> notice that the pkg.keywords and pkg.description items mention that other
> models are supported. I would at least add all of the supported part
> numbers to the pkg.keywords item. That way, anyone searching through the
> code can easily identify that this driver supports all those variants.
>
> On Thu, 2 May 2019 at 14:50, Mario TESI <ma...@st.com> wrote:
>
> > Hi All,
> >
> >
> > As already mentioned in the previous e-mail regarding the lps33hw driver
> > and LPS22HB sensor, I would like to point out
> > that also the LPS22HH sensor is already supported by the lps33thw driver
> > since the registers map and the functionalities
> > are the same, only the package type changes (one is for general purpose
> > the other is for water proof application) and this
> > does not impact the driver's source code
> >
> > If we wanted to declare in mynewt also the support for the sensors
> LPS22HB
> > and LPS22HH how would you suggest to
> > proceed:
> >
> > - Rewriting the drivers for LPS22HB and LPS22HH starting from the LPS33HW
> > and LPS33THW drivers respectively and
> > pushing that as new drivers (in this case the code will be replicated
> > just changing the API name) (I think it's not a the
> > best way) ?
> >
> > or
> >
> > - Adding in the drivers documentation of LPS33HW and LPS33THW the support
> > of the LPS22HB and LPS22HH sensors ?
> >
> >
> > Best Regrds,
> > Mario
> >
> > -------- Forwarded Message --------
> > Subject: lps33hw sensor driver
> > Date: Fri, 12 Apr 2019 17:20:56 +0200
> > From: Mario TESI <ma...@st.com>
> > To: dev@mynewt.apache.org<ma...@mynewt.apache.org>
> >
> >
> >
> > Hi All,
> >
> >
> > I was trying to figure out how to organize the work to add support to
> > MyNewT for the new MEMS sensors produced
> >
> > by STMicroelectronics and I came across the lps33hw driver (hw / driver /
> > sensors / lps33hw) which actually also supports
> >
> > the part number LPS22HB, in fact both devices have
> >
> > - the same Who am I
> >
> > - same functionalities
> >
> > - same register map and bitmap
> >
> > these devices differ only by the case type because LPS33HW is for water
> > proof application while LPS22HB is for generic
> >
> > usage.
> >
> > Would it be possible to indicate in the documentation that the lps33hw
> > driver into the distro supports both LPS33HW and
> >
> > LPS22HB devices (?)
> >
> >
> > Best Regards,
> >
> > Mario
> >
> >
> >
>
--
Regards,
Vipul Rahane
Re: lps33thw sensor driver
Posted by Amr Bekhit <am...@gmail.com>.
Just a suggestion, in the pkg.yml file for the lps33hw package. you'll
notice that the pkg.keywords and pkg.description items mention that other
models are supported. I would at least add all of the supported part
numbers to the pkg.keywords item. That way, anyone searching through the
code can easily identify that this driver supports all those variants.
On Thu, 2 May 2019 at 14:50, Mario TESI <ma...@st.com> wrote:
> Hi All,
>
>
> As already mentioned in the previous e-mail regarding the lps33hw driver
> and LPS22HB sensor, I would like to point out
> that also the LPS22HH sensor is already supported by the lps33thw driver
> since the registers map and the functionalities
> are the same, only the package type changes (one is for general purpose
> the other is for water proof application) and this
> does not impact the driver's source code
>
> If we wanted to declare in mynewt also the support for the sensors LPS22HB
> and LPS22HH how would you suggest to
> proceed:
>
> - Rewriting the drivers for LPS22HB and LPS22HH starting from the LPS33HW
> and LPS33THW drivers respectively and
> pushing that as new drivers (in this case the code will be replicated
> just changing the API name) (I think it's not a the
> best way) ?
>
> or
>
> - Adding in the drivers documentation of LPS33HW and LPS33THW the support
> of the LPS22HB and LPS22HH sensors ?
>
>
> Best Regrds,
> Mario
>
> -------- Forwarded Message --------
> Subject: lps33hw sensor driver
> Date: Fri, 12 Apr 2019 17:20:56 +0200
> From: Mario TESI <ma...@st.com>
> To: dev@mynewt.apache.org<ma...@mynewt.apache.org>
>
>
>
> Hi All,
>
>
> I was trying to figure out how to organize the work to add support to
> MyNewT for the new MEMS sensors produced
>
> by STMicroelectronics and I came across the lps33hw driver (hw / driver /
> sensors / lps33hw) which actually also supports
>
> the part number LPS22HB, in fact both devices have
>
> - the same Who am I
>
> - same functionalities
>
> - same register map and bitmap
>
> these devices differ only by the case type because LPS33HW is for water
> proof application while LPS22HB is for generic
>
> usage.
>
> Would it be possible to indicate in the documentation that the lps33hw
> driver into the distro supports both LPS33HW and
>
> LPS22HB devices (?)
>
>
> Best Regards,
>
> Mario
>
>
>
lps33thw sensor driver
Posted by Mario TESI <ma...@st.com>.
Hi All,
As already mentioned in the previous e-mail regarding the lps33hw driver and LPS22HB sensor, I would like to point out
that also the LPS22HH sensor is already supported by the lps33thw driver since the registers map and the functionalities
are the same, only the package type changes (one is for general purpose the other is for water proof application) and this
does not impact the driver's source code
If we wanted to declare in mynewt also the support for the sensors LPS22HB and LPS22HH how would you suggest to
proceed:
- Rewriting the drivers for LPS22HB and LPS22HH starting from the LPS33HW and LPS33THW drivers respectively and
pushing that as new drivers (in this case the code will be replicated just changing the API name) (I think it's not a the
best way) ?
or
- Adding in the drivers documentation of LPS33HW and LPS33THW the support of the LPS22HB and LPS22HH sensors ?
Best Regrds,
Mario
-------- Forwarded Message --------
Subject: lps33hw sensor driver
Date: Fri, 12 Apr 2019 17:20:56 +0200
From: Mario TESI <ma...@st.com>
To: dev@mynewt.apache.org<ma...@mynewt.apache.org>
Hi All,
I was trying to figure out how to organize the work to add support to MyNewT for the new MEMS sensors produced
by STMicroelectronics and I came across the lps33hw driver (hw / driver / sensors / lps33hw) which actually also supports
the part number LPS22HB, in fact both devices have
- the same Who am I
- same functionalities
- same register map and bitmap
these devices differ only by the case type because LPS33HW is for water proof application while LPS22HB is for generic
usage.
Would it be possible to indicate in the documentation that the lps33hw driver into the distro supports both LPS33HW and
LPS22HB devices (?)
Best Regards,
Mario
lps33thw sensor driver
Posted by Mario TESI <ma...@st.com>.
Hi All,
As already mentioned in the previous e-mail regarding the lps33hw driver and LPS22HB sensor, I would like to point out
that also the LPS22HH sensor is already supported by the lps33thw driver since the registers map and the functionalities
are the same, only the package type changes (one is for general purpose the other is for water proof application) and this
does not impact the driver's source code
If we wanted to declare in mynewt also the support for the sensors LPS22HB and LPS22HH how would you suggest to
proceed:
- Rewriting the drivers for LPS22HB and LPS22HH starting from the LPS33HW and LPS33THW drivers respectively and
pushing that as new drivers (in this case the code will be replicated just changing the API name) (I think it's not a the
best way) ?
or
- Adding in the drivers documentation of LPS33HW and LPS33THW the support of the LPS22HB and LPS22HH sensors ?
Best Regrds,
Mario
-------- Forwarded Message --------
Subject: lps33hw sensor driver
Date: Fri, 12 Apr 2019 17:20:56 +0200
From: Mario TESI <ma...@st.com>
To: dev@mynewt.apache.org<ma...@mynewt.apache.org>
Hi All,
I was trying to figure out how to organize the work to add support to MyNewT for the new MEMS sensors produced
by STMicroelectronics and I came across the lps33hw driver (hw / driver / sensors / lps33hw) which actually also supports
the part number LPS22HB, in fact both devices have
- the same Who am I
- same functionalities
- same register map and bitmap
these devices differ only by the case type because LPS33HW is for water proof application while LPS22HB is for generic
usage.
Would it be possible to indicate in the documentation that the lps33hw driver into the distro supports both LPS33HW and
LPS22HB devices (?)
Best Regards,
Mario