You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/12 18:12:19 UTC

[GitHub] [incubator-druid] leventov commented on a change in pull request #8059: Refactoring to use `CollectionUtils.mapValues`

leventov commented on a change in pull request #8059: Refactoring to use `CollectionUtils.mapValues`
URL: https://github.com/apache/incubator-druid/pull/8059#discussion_r303088593
 
 

 ##########
 File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java
 ##########
 @@ -266,6 +266,7 @@ protected SeekableStreamIndexTaskIOConfig createTaskIoConfig(
 
 
   @Override
+  @SuppressWarnings("SSBasedInspection")
 
 Review comment:
   When suppressing `SSBasedInspection`, please always add a comment -- what specifically you suppress (`mapValues()` in this case), and why -- it's not obvious for me in this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org