You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2022/05/22 14:51:36 UTC
[incubator-doris] 11/13: [config](checksum) Disable consistency checker by default (#9699)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit c4c436453495d293c700e10bd0aced53b38f86be
Author: Mingyu Chen <mo...@gmail.com>
AuthorDate: Sun May 22 21:31:43 2022 +0800
[config](checksum) Disable consistency checker by default (#9699)
Disable by default because current checksum logic has some bugs.
And it will also bring some overhead.
---
docs/en/administrator-guide/config/fe_config.md | 10 +++++++---
docs/zh-CN/administrator-guide/config/fe_config.md | 10 +++++++---
fe/fe-core/src/main/java/org/apache/doris/common/Config.java | 7 +++++--
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java | 3 ++-
4 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/docs/en/administrator-guide/config/fe_config.md b/docs/en/administrator-guide/config/fe_config.md
index e68e6a56ee..bfef450d17 100644
--- a/docs/en/administrator-guide/config/fe_config.md
+++ b/docs/en/administrator-guide/config/fe_config.md
@@ -1021,17 +1021,21 @@ IsMutable：true
MasterOnly：true
-Consistency checker will run from *consistency_check_start_time* to *consistency_check_end_time*. Default is from 23:00 to 04:00
+Consistency checker will run from *consistency_check_start_time* to *consistency_check_end_time*.
+
+If the two times are the same, no consistency check will be triggered.
### consistency_check_end_time
-Default：04
+Default：23
IsMutable：true
MasterOnly：true
-Consistency checker will run from *consistency_check_start_time* to *consistency_check_end_time*. Default is from 23:00 to 04:00
+Consistency checker will run from *consistency_check_start_time* to *consistency_check_end_time*.
+
+If the two times are the same, no consistency check will be triggered.
### export_tablet_num_per_task
diff --git a/docs/zh-CN/administrator-guide/config/fe_config.md b/docs/zh-CN/administrator-guide/config/fe_config.md
index e082155212..0528430a60 100644
--- a/docs/zh-CN/administrator-guide/config/fe_config.md
+++ b/docs/zh-CN/administrator-guide/config/fe_config.md
@@ -1021,11 +1021,13 @@ colocote join PlanFragment instance 的 memory_limit = exec_mem_limit / min (que
一致性检查开始时间
-一致性检查器将从 `consistency_check_start_time` 运行到 `consistency_check_end_time`。 默认为 23:00 至 04:00
+一致性检查器将从 `consistency_check_start_time` 运行到 `consistency_check_end_time`。
+
+如果两个时间相同，则不会触发一致性检查。
### `consistency_check_end_time`
-默认值：04
+默认值：23
是否可以动态配置：true
@@ -1033,7 +1035,9 @@ colocote join PlanFragment instance 的 memory_limit = exec_mem_limit / min (que
一致性检查结束时间
-一致性检查器将从 `consistency_check_start_time` 运行到 `consistency_check_end_time`。 默认为 23:00 至 04:00
+一致性检查器将从 `consistency_check_start_time` 运行到 `consistency_check_end_time`。
+
+如果两个时间相同，则不会触发一致性检查。
### `export_tablet_num_per_task`
diff --git a/fe/fe-core/src/main/java/org/apache/doris/common/Config.java b/fe/fe-core/src/main/java/org/apache/doris/common/Config.java
index 14e827f3ab..6660d5e63c 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/common/Config.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/common/Config.java
@@ -841,12 +841,15 @@ public class Config extends ConfigBase {
// Configurations for consistency check
/**
* Consistency checker will run from *consistency_check_start_time* to *consistency_check_end_time*.
- * Default is from 23:00 to 04:00
+ * If start time == end time, the checker will stop scheduling.
+ * And default is disabled.
+ * TODO(cmy): Disable by default because current checksum logic has some bugs.
+ * And it will also bring some overhead.
*/
@ConfField(mutable = true, masterOnly = true)
public static String consistency_check_start_time = "23";
@ConfField(mutable = true, masterOnly = true)
- public static String consistency_check_end_time = "4";
+ public static String consistency_check_end_time = "23";
/**
* Default timeout of a single consistency check task. Set long enough to fit your tablet size.
*/
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
index 91083f2e1f..7c050bdc2c 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
@@ -640,7 +640,8 @@ public class Coordinator {
switch (code) {
case TIMEOUT:
throw new RpcException(pair.first.backend.getHost(), "send fragment timeout. backend id: "
- + pair.first.backend.getId());
+ + pair.first.backend.getId() + " fragment: " +
+ DebugUtil.printId(pair.first.rpcParams.params.fragment_instance_id));
case THRIFT_RPC_ERROR:
SimpleScheduler.addToBlacklist(pair.first.backend.getId(), errMsg);
throw new RpcException(pair.first.backend.getHost(), "rpc failed");
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org