[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3377: add feature , request can be handle by self-defined class

[GitBox <gi...@apache.org>]

liubao68 commented on code in PR #3377:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3377#discussion_r984255517


##########
governance/src/main/java/org/apache/servicecomb/governance/marker/TrafficMarker.java:
##########
@@ -23,6 +23,10 @@
 public class TrafficMarker extends Configurable {
   private List<Matcher> matches;
 
+  private String profileValues;
+
+  private String profileExtractClass;

Review Comment:
   I think it is not a good idea to create these two properties here. We need to keep the specification clear and clarity, see https://github.com/huaweicloud/spring-cloud-huawei/wiki/using-governance
   
   First of all, we should keep the specification language independent. For your requirement, I think you can add this logic when you create your governance request, and set the header you need. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org