[GitHub] [avro] opwvhk commented on a change in pull request #985: AVRO-2976: Add LogicalType parsing to the IDL

[GitBox <gi...@apache.org>]

opwvhk commented on a change in pull request #985:
URL: https://github.com/apache/avro/pull/985#discussion_r763818860



##########
File path: lang/java/compiler/src/main/javacc/org/apache/avro/compiler/idl/idl.jj
##########
@@ -1058,6 +1059,9 @@ private Schema NamedSchemaDeclaration(Map<String, JsonNode> props):
      } else {                                     // add all other props
        Accessor.addProp(s, key, props.get(key));
      }
+   LogicalType logicalType = LogicalTypes.fromSchemaIgnoreInvalid(s);
+   if (logicalType != null)
+     logicalType.addToSchema(s);

Review comment:
       Every time we apply properties to a schema, we should call this logic.
   It determines the logical type of the schema, and applies it if possible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org