You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/02/10 22:51:56 UTC
[GitHub] [samza] rmatharu commented on a change in pull request #1267:
SAMZA-2402: Tie Container placement service and Container placement handler
and validate placement requests
rmatharu commented on a change in pull request #1267: SAMZA-2402: Tie Container placement service and Container placement handler and validate placement requests
URL: https://github.com/apache/samza/pull/1267#discussion_r377365231
##########
File path: samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -452,7 +457,7 @@ StartpointManager createStartpointManager() {
@VisibleForTesting
ContainerProcessManager createContainerProcessManager() {
- return new ContainerProcessManager(config, state, metrics);
+ return new ContainerProcessManager(config, state, metrics, containerPlacementMetadataStore);
}
Review comment:
Does this constructor call really warrant a new method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services