[GitHub] [skywalking-client-js] kezhenxu94 commented on a change in pull request #23: feat: trace segments and set http header

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-client-js/pull/23#discussion_r549226933



##########
File path: src/errors/ajax.ts
##########
@@ -28,7 +28,7 @@ class AjaxErrors extends Base {
     const xhrSend = XMLHttpRequest.prototype.send;
     const xhrEvent = (event: any) => {
       try {
-        if (event && event.currentTarget && event.currentTarget.status !== 200) {
+        if (event && event.currentTarget && event.currentTarget.status !== 200 && event.currentTarget.status !== 304) {

Review comment:
       Most (if not all) of the other agents use a condition `status >= 400` to determine the status is `error` or not, does it apply to this agent too?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org