You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "TOGEP (via GitHub)" <gi...@apache.org> on 2026/08/20 06:07:42 UTC
[PR] fix: make service ports configurable [devlake-helm-chart]
TOGEP opened a new pull request, #380:
URL: https://github.com/apache/devlake-helm-chart/pull/380
## Summary
Make the MySQL and UI Service ports configurable through `values.yaml`
Also replace hard-coded ports in the Lake and Grafana endpoints with their existing configured values.
Fixes #372
## Changes
- Add `mysql.service.port` (default: `3306`)
- Add `ui.service.port` (default: `4000`)
- Document the new values in `HelmSetup.md`
The default values remain unchanged, so existing installations are not affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: make service ports configurable [devlake-helm-chart]
Posted by "TOGEP (via GitHub)" <gi...@apache.org>.
TOGEP commented on code in PR #380:
URL: https://github.com/apache/devlake-helm-chart/pull/380#discussion_r3819046133
##########
charts/devlake/templates/deployments.yaml:
##########
@@ -86,15 +87,15 @@ spec:
{{- end }}
env:
- name: DEVLAKE_ENDPOINT
- value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:8080
+ value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.lake.port }}
Review Comment:
`lake.port` was introduced in #144, but this endpoint continued to use the hard-coded port `8080`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: make service ports configurable [devlake-helm-chart]
Posted by "TOGEP (via GitHub)" <gi...@apache.org>.
TOGEP commented on PR #380:
URL: https://github.com/apache/devlake-helm-chart/pull/380#issuecomment-5364418756
🤔
https://github.com/apache/devlake-helm-chart/actions/runs/32338299965/job/96645343915#step:7:13
```
/usr/local/bin/kind: line 1: !DOCTYPE: No such file or directory
/usr/local/bin/kind: line 2: !--
/usr/local/bin/kind: line 4: Hello: command not found
/usr/local/bin/kind: line 7: unexpected EOF while looking for matching `''
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: make service ports configurable [devlake-helm-chart]
Posted by "TOGEP (via GitHub)" <gi...@apache.org>.
TOGEP commented on PR #380:
URL: https://github.com/apache/devlake-helm-chart/pull/380#issuecomment-5364443929
The `mysql-external` job failed while downloading the kind binary and appears to be a transient CI issue.
The parallel `mysql-builtin` job completed successfully
I do not have permission to re-run the failed job. Could a maintainer please re-run it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: make service ports configurable [devlake-helm-chart]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #380:
URL: https://github.com/apache/devlake-helm-chart/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: make service ports configurable [devlake-helm-chart]
Posted by "TOGEP (via GitHub)" <gi...@apache.org>.
TOGEP commented on code in PR #380:
URL: https://github.com/apache/devlake-helm-chart/pull/380#discussion_r3819046133
##########
charts/devlake/templates/deployments.yaml:
##########
@@ -86,15 +87,15 @@ spec:
{{- end }}
env:
- name: DEVLAKE_ENDPOINT
- value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:8080
+ value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.lake.port }}
Review Comment:
`lake.port` was already configurable, but this endpoint still used the hard-coded port `8080`.
As a result, changing `lake.port` did not work end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: make service ports configurable [devlake-helm-chart]
Posted by "TOGEP (via GitHub)" <gi...@apache.org>.
TOGEP commented on code in PR #380:
URL: https://github.com/apache/devlake-helm-chart/pull/380#discussion_r3819046133
##########
charts/devlake/templates/deployments.yaml:
##########
@@ -86,15 +87,15 @@ spec:
{{- end }}
env:
- name: DEVLAKE_ENDPOINT
- value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:8080
+ value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.lake.port }}
Review Comment:
`lake.port` was already configurable, but this endpoint still used the hard-coded port `8080`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org