[GitHub] markusthoemmes commented on a change in pull request #3741: Cleaning up the test related classes

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3741: Cleaning up the test related classes 
URL: https://github.com/apache/incubator-openwhisk/pull/3741#discussion_r198582853
 
 

 ##########
 File path: tests/src/test/scala/common/rest/WskRest.scala
 ##########
 @@ -1114,32 +1104,31 @@ class WskRestApi extends RunWskRestCmd with BaseApi {
                     expectedExitCode: Int = SUCCESS_EXIT,
                     cliCfgFile: Option[String] = None)(implicit wp: WskProps): RestResult = {
 
-    val parms = Map[String, JsValue]() ++ {
+    val parms = {
       basepathOrApiName map { b =>
         Map("basepath" -> b.toJson)
-      } getOrElse Map[String, JsValue]()
+      } getOrElse Map.empty
 
 Review comment:
   There's none I believe, I tend to use your way of of writing @mdeuser because it feels more explicit, but that's just me. The compiler also tends to get funny with infix notation in some edge-cases, so I usually avoid that alltogether.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services