You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2016/02/02 19:52:41 UTC

Review Request 43104: Reverting deprecated field removal patches.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43104/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-1603
    https://issues.apache.org/jira/browse/AURORA-1603


Repository: aurora


Description
-------

The cleanest way is to revert both commits below. Otherwise, there is a nasty conflict to resolve when we un-revert these patches in 0.13.0.

This reverts commit e1b55fa544765c12251ce6c1736e6352da3f7edb.

This reverts commit 89fad5a8895482b6c3fa45356137aa250d766dfe.


Diffs
-----

  NEWS aef8a1aab2fee74ded8e1666f795885380690247 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 8409c9bbae53ddc200132fb3c4c0a6eb6a4fcbf4 
  src/main/java/org/apache/aurora/scheduler/base/Query.java ee01eaa4d0230d6bf0909b6460f27a74f03240db 
  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
  src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0 
  src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java eb848add00fba6d3571657bb9080be0599b2756a 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d217faf44ab3d6132db3b3c4eed67effd03fb6fa 
  src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af 
  src/main/python/apache/aurora/client/api/sla.py e282ec96ec6999492f712d072f7ab1c09c022474 
  src/main/python/apache/aurora/client/cli/jobs.py 67ab4f01eca911aea041328410c6104b63ff8344 
  src/main/python/apache/aurora/client/cli/task.py a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
  src/main/python/apache/aurora/config/thrift.py be0cd68674a71bd4baadf276f40a4bc0223ce4be 
  src/main/python/apache/aurora/executor/common/announcer.py 34e36e0a59093468a8934f58bacb68512949347c 
  src/main/python/apache/aurora/executor/common/sandbox.py 4780232318ffdf8c6bbbe78bee518886cffd580a 
  src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 1434f45ca0bc188bfb0f2ef3c25fbcd102a3ccb1 
  src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml b1394cf44b7ddafcbc47bb1968306d0b33293380 
  src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml ae52c402ee131167ca6099dd8218ce7315fede4c 
  src/main/resources/scheduler/assets/js/controllers.js 84417ebeadfae57d55b9f12e8a985825bd620fc8 
  src/main/resources/scheduler/assets/js/services.js d9ce52065f9573b0aa68a95da7da7c50fb14310a 
  src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 469b53b2ab9407ad7cab41deee757207c75af985 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 3c5ecd698557cafdf8eeacdc472589a379018896 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java b6f5e4632ac1e028fdf93da1735463373e2d2788 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java c316e497a34a45c7ada2ca83a1115e826c0f572f 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java be98f3862d537602c05275ba2466e2fdbf5e9b55 
  src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 3ba03429748448642571cfe0858278a50148745a 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java c774ac0f0e2fdda7fe9b64fd9181f107b3fd9eca 
  src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 09d13a3abf72a25c5b7bfc1d7db3bdfb8ec11c6d 
  src/test/python/apache/aurora/admin/test_admin.py 22605ec8c28cf6d3b66c3dacc9634776d0afe8ff 
  src/test/python/apache/aurora/client/api/test_api.py 974fc7e5a8ea13020e2c01a2088a8535947f05bc 
  src/test/python/apache/aurora/client/api/test_sla.py 2bc2dd965ac0d7e2d959771b5a33ddc942bda734 
  src/test/python/apache/aurora/client/cli/test_status.py 7f36b4627bdbaaec4e6358500beeb143de4fcb7a 
  src/test/python/apache/aurora/client/cli/util.py 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
  src/test/python/apache/aurora/config/test_thrift.py 88292d3c4423c0555088a0adaee3c0e62ed0567e 
  src/test/python/apache/aurora/executor/common/test_announcer.py f4032c7302f4733ab5670322b1905102c200f1c9 
  src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py fe74bd1d36666ecd89fca1b5b2251202cbbc0f24 
  src/test/python/apache/aurora/executor/test_thermos_executor.py ef60ec2d654d7dfc839df5110a80fe70a80a5d63 

Diff: https://reviews.apache.org/r/43104/diff/


Testing
-------

./gradlew -Pq build
e2e tests


Thanks,

Maxim Khutornenko

Re: Review Request 43104: Reverting deprecated field removal patches.

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43104/#review117446
-----------------------------------------------------------


Ship it!




Ship It!

- Bill Farner


On Feb. 2, 2016, 10:52 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43104/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 10:52 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1603
>     https://issues.apache.org/jira/browse/AURORA-1603
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The cleanest way is to revert both commits below. Otherwise, there is a nasty conflict to resolve when we un-revert these patches in 0.13.0.
> 
> This reverts commit e1b55fa544765c12251ce6c1736e6352da3f7edb.
> 
> This reverts commit 89fad5a8895482b6c3fa45356137aa250d766dfe.
> 
> 
> Diffs
> -----
> 
>   NEWS aef8a1aab2fee74ded8e1666f795885380690247 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 8409c9bbae53ddc200132fb3c4c0a6eb6a4fcbf4 
>   src/main/java/org/apache/aurora/scheduler/base/Query.java ee01eaa4d0230d6bf0909b6460f27a74f03240db 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java eb848add00fba6d3571657bb9080be0599b2756a 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d217faf44ab3d6132db3b3c4eed67effd03fb6fa 
>   src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/client/api/sla.py e282ec96ec6999492f712d072f7ab1c09c022474 
>   src/main/python/apache/aurora/client/cli/jobs.py 67ab4f01eca911aea041328410c6104b63ff8344 
>   src/main/python/apache/aurora/client/cli/task.py a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/main/python/apache/aurora/config/thrift.py be0cd68674a71bd4baadf276f40a4bc0223ce4be 
>   src/main/python/apache/aurora/executor/common/announcer.py 34e36e0a59093468a8934f58bacb68512949347c 
>   src/main/python/apache/aurora/executor/common/sandbox.py 4780232318ffdf8c6bbbe78bee518886cffd580a 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 1434f45ca0bc188bfb0f2ef3c25fbcd102a3ccb1 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml b1394cf44b7ddafcbc47bb1968306d0b33293380 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml ae52c402ee131167ca6099dd8218ce7315fede4c 
>   src/main/resources/scheduler/assets/js/controllers.js 84417ebeadfae57d55b9f12e8a985825bd620fc8 
>   src/main/resources/scheduler/assets/js/services.js d9ce52065f9573b0aa68a95da7da7c50fb14310a 
>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 469b53b2ab9407ad7cab41deee757207c75af985 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 3c5ecd698557cafdf8eeacdc472589a379018896 
>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java b6f5e4632ac1e028fdf93da1735463373e2d2788 
>   src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java c316e497a34a45c7ada2ca83a1115e826c0f572f 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java be98f3862d537602c05275ba2466e2fdbf5e9b55 
>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 3ba03429748448642571cfe0858278a50148745a 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java c774ac0f0e2fdda7fe9b64fd9181f107b3fd9eca 
>   src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 09d13a3abf72a25c5b7bfc1d7db3bdfb8ec11c6d 
>   src/test/python/apache/aurora/admin/test_admin.py 22605ec8c28cf6d3b66c3dacc9634776d0afe8ff 
>   src/test/python/apache/aurora/client/api/test_api.py 974fc7e5a8ea13020e2c01a2088a8535947f05bc 
>   src/test/python/apache/aurora/client/api/test_sla.py 2bc2dd965ac0d7e2d959771b5a33ddc942bda734 
>   src/test/python/apache/aurora/client/cli/test_status.py 7f36b4627bdbaaec4e6358500beeb143de4fcb7a 
>   src/test/python/apache/aurora/client/cli/util.py 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
>   src/test/python/apache/aurora/config/test_thrift.py 88292d3c4423c0555088a0adaee3c0e62ed0567e 
>   src/test/python/apache/aurora/executor/common/test_announcer.py f4032c7302f4733ab5670322b1905102c200f1c9 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py fe74bd1d36666ecd89fca1b5b2251202cbbc0f24 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py ef60ec2d654d7dfc839df5110a80fe70a80a5d63 
> 
> Diff: https://reviews.apache.org/r/43104/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> e2e tests
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43104: Reverting deprecated field removal patches.

Posted by John Sirois <js...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43104/#review117445
-----------------------------------------------------------


Ship it!




Ship It!

- John Sirois


On Feb. 2, 2016, 11:52 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43104/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 11:52 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1603
>     https://issues.apache.org/jira/browse/AURORA-1603
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The cleanest way is to revert both commits below. Otherwise, there is a nasty conflict to resolve when we un-revert these patches in 0.13.0.
> 
> This reverts commit e1b55fa544765c12251ce6c1736e6352da3f7edb.
> 
> This reverts commit 89fad5a8895482b6c3fa45356137aa250d766dfe.
> 
> 
> Diffs
> -----
> 
>   NEWS aef8a1aab2fee74ded8e1666f795885380690247 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 8409c9bbae53ddc200132fb3c4c0a6eb6a4fcbf4 
>   src/main/java/org/apache/aurora/scheduler/base/Query.java ee01eaa4d0230d6bf0909b6460f27a74f03240db 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java eb848add00fba6d3571657bb9080be0599b2756a 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d217faf44ab3d6132db3b3c4eed67effd03fb6fa 
>   src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/client/api/sla.py e282ec96ec6999492f712d072f7ab1c09c022474 
>   src/main/python/apache/aurora/client/cli/jobs.py 67ab4f01eca911aea041328410c6104b63ff8344 
>   src/main/python/apache/aurora/client/cli/task.py a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/main/python/apache/aurora/config/thrift.py be0cd68674a71bd4baadf276f40a4bc0223ce4be 
>   src/main/python/apache/aurora/executor/common/announcer.py 34e36e0a59093468a8934f58bacb68512949347c 
>   src/main/python/apache/aurora/executor/common/sandbox.py 4780232318ffdf8c6bbbe78bee518886cffd580a 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 1434f45ca0bc188bfb0f2ef3c25fbcd102a3ccb1 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml b1394cf44b7ddafcbc47bb1968306d0b33293380 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml ae52c402ee131167ca6099dd8218ce7315fede4c 
>   src/main/resources/scheduler/assets/js/controllers.js 84417ebeadfae57d55b9f12e8a985825bd620fc8 
>   src/main/resources/scheduler/assets/js/services.js d9ce52065f9573b0aa68a95da7da7c50fb14310a 
>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 469b53b2ab9407ad7cab41deee757207c75af985 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 3c5ecd698557cafdf8eeacdc472589a379018896 
>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java b6f5e4632ac1e028fdf93da1735463373e2d2788 
>   src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java c316e497a34a45c7ada2ca83a1115e826c0f572f 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java be98f3862d537602c05275ba2466e2fdbf5e9b55 
>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 3ba03429748448642571cfe0858278a50148745a 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java c774ac0f0e2fdda7fe9b64fd9181f107b3fd9eca 
>   src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 09d13a3abf72a25c5b7bfc1d7db3bdfb8ec11c6d 
>   src/test/python/apache/aurora/admin/test_admin.py 22605ec8c28cf6d3b66c3dacc9634776d0afe8ff 
>   src/test/python/apache/aurora/client/api/test_api.py 974fc7e5a8ea13020e2c01a2088a8535947f05bc 
>   src/test/python/apache/aurora/client/api/test_sla.py 2bc2dd965ac0d7e2d959771b5a33ddc942bda734 
>   src/test/python/apache/aurora/client/cli/test_status.py 7f36b4627bdbaaec4e6358500beeb143de4fcb7a 
>   src/test/python/apache/aurora/client/cli/util.py 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
>   src/test/python/apache/aurora/config/test_thrift.py 88292d3c4423c0555088a0adaee3c0e62ed0567e 
>   src/test/python/apache/aurora/executor/common/test_announcer.py f4032c7302f4733ab5670322b1905102c200f1c9 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py fe74bd1d36666ecd89fca1b5b2251202cbbc0f24 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py ef60ec2d654d7dfc839df5110a80fe70a80a5d63 
> 
> Diff: https://reviews.apache.org/r/43104/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> e2e tests
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>