You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Matej Knopp (JIRA)" <ji...@apache.org> on 2007/10/21 16:08:50 UTC
[jira] Reopened: (WICKET-1090) clean up raw_input after rendering
of form components
[ https://issues.apache.org/jira/browse/WICKET-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp reopened WICKET-1090:
---------------------------------
The fix definitely doesn't seem right. There is reason why the raw input is persisted across request - it contains the invalid (non-validated) user input that we have to persist.
> clean up raw_input after rendering of form components
> -----------------------------------------------------
>
> Key: WICKET-1090
> URL: https://issues.apache.org/jira/browse/WICKET-1090
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3, 1.3.0-beta4
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.0-beta5
>
>
> This code doesn't work like it should:
> super("createUserForm", new CompoundPropertyModel(bean));
> final TextField passwordField = new TextField("password");
> passwordField.setOutputMarkupId(true);
> passwordField.setLabel(new ResourceModel("label.createuser.password"));
> add(passwordField);
> add(new AjaxLink("generatePasswordLink") {
> @Override
> public void onClick(AjaxRequestTarget target) {
> bean.setPassword(PasswordGenerator.generate().toString());
> target.addComponent(passwordField);
> }
> });
> It should update the label with the new password, but it doesn't when done after a form submit since it still has the raw_input value it got from that last form submit. There is no reason (as far as I know) to hold on to that value after rendering, so the fix is to clean the raw_input at the end of requests (i.e. onAfterRender).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.