You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Pankaj Kumar (Jira)" <ji...@apache.org> on 2021/03/12 12:32:00 UTC

[jira] [Commented] (HBASE-25662) Fix spotbugs warning in RoundRobinTableInputFormat

    [ https://issues.apache.org/jira/browse/HBASE-25662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300273#comment-17300273 ] 

Pankaj Kumar commented on HBASE-25662:
--------------------------------------

Oops.. missed the conversation in HBASE-25566 PR,

https://github.com/apache/hbase/pull/2947#issuecomment-797230711

[~zhangduo], should we add this in spotbugs-exclude.xml?

> Fix spotbugs warning in RoundRobinTableInputFormat
> --------------------------------------------------
>
>                 Key: HBASE-25662
>                 URL: https://issues.apache.org/jira/browse/HBASE-25662
>             Project: HBase
>          Issue Type: Bug
>          Components: findbugs
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Major
>
> RoundRobinTableInputFormat.roundRobin(List) makes inefficient use of keySet iterator instead of entrySet iterator,
> https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3043/2/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)