[GitHub] [pulsar] Shoothzj commented on a change in pull request #14670: Optimize ClientBuilderImpl

[GitBox <gi...@apache.org>]

Shoothzj commented on a change in pull request #14670:
URL: https://github.com/apache/pulsar/pull/14670#discussion_r825433125



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
##########
@@ -339,7 +328,8 @@ public ClientBuilder enableTransaction(boolean enableTransaction) {
 
     @Override
     public ClientBuilder dnsLookupBind(String address, int port) {
-        checkArgument(port >= 0 && port <= 65535, "DnsLookBindPort need to be within the range of 0 and 65535");
+        checkArgument(port >= 0 && port <= 65535,

Review comment:
       is that a unnecessary format?

##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
##########
@@ -79,15 +75,13 @@ public ClientBuilder clone() {
     @Override
     public ClientBuilder loadConf(Map<String, Object> config) {
         conf = ConfigurationDataUtils.loadData(
-            config, conf, ClientConfigurationData.class);
+                config, conf, ClientConfigurationData.class);

Review comment:
       is that a unnecessary format?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org