You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/15 02:57:25 UTC
[GitHub] [orc] guiyanakuang opened a new pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
guiyanakuang opened a new pull request #908:
URL: https://github.com/apache/orc/pull/908
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
Declare dependence orc-shims.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix Build.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #908:
URL: https://github.com/apache/orc/pull/908#discussion_r708804939
##########
File path: java/examples/pom.xml
##########
@@ -36,6 +36,10 @@
<groupId>org.apache.orc</groupId>
<artifactId>orc-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.orc</groupId>
+ <artifactId>orc-shims</artifactId>
+ </dependency>
Review comment:
CI seems to fail by this addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919662933
> BTW, I sent you an email ([guiyanakuang@gmail.com](mailto:guiyanakuang@gmail.com)) via Gmail. Did you check it?
Sorry I just saw the email.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919666186
BTW, please participate the votes. We have three votes in the dev mailing list. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919665869
No problem. I just want to reach out to you. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-920143664
Thank you for the confirming, @guiyanakuang . :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919658994
BTW, I sent you an email (guiyanakuang@gmail.com) via Gmail. Did you check it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang closed pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
guiyanakuang closed pull request #908:
URL: https://github.com/apache/orc/pull/908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919661965
> Thank you. Is this `main` only issue?
It should be a problem caused by the merge of ORC-910, so I think only main is affected at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on a change in pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on a change in pull request #908:
URL: https://github.com/apache/orc/pull/908#discussion_r708805448
##########
File path: java/examples/pom.xml
##########
@@ -36,6 +36,10 @@
<groupId>org.apache.orc</groupId>
<artifactId>orc-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.orc</groupId>
+ <artifactId>orc-shims</artifactId>
+ </dependency>
Review comment:
I don't know why, but the current build prompt is the opposite of my environment, and I need some time to make sure to analyze it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919658669
Thank you. Is this `main` only issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919736530
Sorry, orc-example does not directly depend on orc-shims. It's just a problem with my env, I will close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org