[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source
URL: https://github.com/apache/spark/pull/24548#discussion_r281848417
 
 

 ##########
 File path: docs/structured-streaming-programming-guide.md
 ##########
 @@ -541,6 +541,8 @@ Here are the details of all the sources in Spark.
         <br/>
         <code>fileNameOnly</code>: whether to check new files based on only the filename instead of on the full path (default: false). With this set to `true`, the following files would be considered as the same file, because their filenames, "dataset.txt", are the same:
         <br/>
+        <code>maxFileAge</code>: Maximum age of a file that can be found in this directory, before it is ignored. For the first batch all files will be considered valid. If `latestFirst` is set to `true` and `maxFilesPerTrigger` is set, then this parameter will be ignored, because old files that are valid, and should be processed, may be ignored. The max age is specified with respect to the timestamp of the latest file, and not the timestamp of the current system.(default: a week)
 
 Review comment:
   According to the attached image, it seems that we need the following changes.
   ```
   - If `latestFirst` is set to `true` and `maxFilesPerTrigger`
   + If <code>latestFirst</code> is set to `true` and <code>maxFilesPerTrigger</code>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org