You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/01/20 16:28:52 UTC
[GitHub] flink pull request: [FLINK-3267] Disable reference tracking in Kry...
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1528
[FLINK-3267] Disable reference tracking in Kryo fallback serializer
Before this commit, Kryo runs extra logic to track and resolve repeated references to
the same object (similar as JavaSerialization)
This disables reference tracking because
- reference tracking is costly
- it is virtually always unnecessary in the datatypes used in Flink
- it is inconsistent with Flink's own serialization (which does not do reference tracking)
- it may have problems if elements are read in a different order than they are written.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink kryo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1528.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1528
----
commit cb94002f4b38090d21e0baadbd5964ebb9c4de9d
Author: Stephan Ewen <se...@apache.org>
Date: 2016-01-20T15:26:58Z
[FLINK-3267] Disable reference tracking in Kryo fallback serializer
Before this commit, Kryo runs extra logic to track and resolve repeated references to
the same object (similar as JavaSerialization)
This disables reference tracking because
- reference tracking is costly
- it is virtually always unnecessary in the datatypes used in Flink
- it is inconsistent with Flink's own serialization (which does not do reference tracking)
- it may have problems if elements are read in a different order than they are written.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3267] Disable reference tracking in Kry...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1528#issuecomment-173509879
Sure makes sense :-)
On Jan 20, 2016 7:23 PM, "Stephan Ewen" <no...@github.com> wrote:
> Trigger was a mail from Theo on the ML where deserialization failes in the
> reference mapper. There may be another issue still, but a failure in a code
> that is better not executed seemed avoidable ;-)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/flink/pull/1528#issuecomment-173314485>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3267] Disable reference tracking in Kry...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1528#issuecomment-173276572
Just curious, was there an issue with this? Or how did you stumble upon the reference tracking?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3267] Disable reference tracking in Kry...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1528
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3267] Disable reference tracking in Kry...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1528#issuecomment-173314485
Trigger was a mail from Theo on the ML where deserialization failes in the reference mapper. There may be another issue still, but a failure in a code that is better not executed seemed avoidable ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---