You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CRZbulabula (via GitHub)" <gi...@apache.org> on 2023/08/22 13:57:17 UTC

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #10924: [IOTDB-6125] Fix DataPartition allocation bug when insert big batch data

CRZbulabula commented on code in PR #10924:
URL: https://github.com/apache/iotdb/pull/10924#discussion_r1301692098


##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java:
##########
@@ -559,8 +559,13 @@ private TSStatus autoExtendRegionGroupIfNecessary(
             (int)
                 Math.min(
                     unassignedPartitionSlotsCount, minRegionGroupNum - allocatedRegionGroupCount);
-        allotmentMap.put(database, delta);
-        continue;
+        if (slotCount <= (maxSlotCount / maxRegionGroupCount) * minRegionGroupNum) {

Review Comment:
   Good point! I've fixed this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org