You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by khawkins <gi...@git.apache.org> on 2014/10/07 23:10:08 UTC
[GitHub] cordova-js pull request: Some user agent-related changes in suppor...
GitHub user khawkins opened a pull request:
https://github.com/apache/cordova-js/pull/84
Some user agent-related changes in support of CB-2520
Changes in correlation with the PR fix [here](https://github.com/apache/cordova-ios/pull/112).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khawkins/cordova-js CB-2520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit a7e31ebff5f9e3c70e2ecd2ca908bb9b71c738fe
Author: Kevin Hawkins <kh...@salesforce.com>
Date: 2014-10-07T21:09:32Z
Some user agent-related changes in support of CB-2520
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: Some user agent-related changes in suppor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: Some user agent-related changes in suppor...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/84#discussion_r18549351
--- Diff: src/ios/exec.js ---
@@ -230,7 +223,7 @@ function pokeNativeViaXhr() {
// Add a timestamp to the query param to prevent caching.
execXhr.open('HEAD', "/!gap_exec?" + (+new Date()), true);
if (!vcHeaderValue) {
- vcHeaderValue = /.*\((.*)\)/.exec(navigator.userAgent)[1];
+ vcHeaderValue = /.*\((.*)\)$/.exec(navigator.userAgent)[1];
--- End diff --
In the wake of configurable user agents, this is more deterministic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: Some user agent-related changes in suppor...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/84#discussion_r18549338
--- Diff: src/ios/exec.js ---
@@ -131,15 +131,8 @@ function convertMessageToArgsNativeToJs(message) {
}
function iOSExec() {
- // Use XHR for iOS 5 to work around a bug in -webkit-scroll.
--- End diff --
Since iOS 6 is now the minimum, took this check out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org