You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/08/04 05:13:23 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #768: Add `StatusOr` for error handling in modern C++ style

git-hulk commented on PR #768:
URL: https://github.com/apache/incubator-kvrocks/pull/768#issuecomment-1204768544

   To be honest, this change looks a bit complex at first glance. 
   But after taking a look at how the Status/StatusOr works and uses, 
   I think it can simplify a lot on how we add a new status code
   and return a status with value. 
   
   For myself, I would happy to see that we can use the modern way
   to improve our codebase, even it needs some time to learn for guys
   from C or legacy C++ code style.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org