You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2002/07/17 20:48:52 UTC

[PATCH] C-L POST body wouldn't report EOS

Attached is a patch that should allow ap_get_brigade() modules to
determine EOS on the same roundtrip as the last read of the request
body contents.

Right now, the caller won't receive an EOS.  Coupled with our useless
r->remaining req_rec member, there is no way to determine if there is
no data left to read.

With this patch, pulling a small (say, 200 byte) POST request will
now return the 200 byte bucket, plus the EOS bucket signifying that
we have nothing left to read from the client.

I don't have any immediate proposal on chunked post bodies, but this
should be considered separately any ways.

Bill


Re: [PATCH] C-L POST body wouldn't report EOS

Posted by Brian Pane <br...@apache.org>.
Justin Erenkrantz wrote:

>On Wed, Jul 17, 2002 at 01:48:52PM -0500, William A. Rowe, Jr. wrote:
>  
>
>>Attached is a patch that should allow ap_get_brigade() modules to
>>determine EOS on the same roundtrip as the last read of the request
>>body contents.
>>    
>>
>
>+1.  -- justin
>

I haven't had a chance to look at the code, but +1 on the concept.

--Brian




Re: [PATCH] C-L POST body wouldn't report EOS

Posted by Justin Erenkrantz <je...@apache.org>.
On Wed, Jul 17, 2002 at 01:48:52PM -0500, William A. Rowe, Jr. wrote:
> Attached is a patch that should allow ap_get_brigade() modules to
> determine EOS on the same roundtrip as the last read of the request
> body contents.

+1.  -- justin