[jira] [Closed] (MSHADE-363) Breaking change to ResourceTransformer's API

["Herve Boutemy (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MSHADE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Herve Boutemy closed MSHADE-363.
--------------------------------
      Assignee: Herve Boutemy
    Resolution: Fixed

merged to master:
1. IT to show the failure and check the fix in https://github.com/apache/maven-shade-plugin/commit/51bbf72e195e34229a1d3ebba2f9608255068a9d
2. changed ResourceTransformer back and added ReproducibleResourceTransformer for the new reproducible behaviour in https://github.com/apache/maven-shade-plugin/commit/229f4d79836b20a17dd8291e3734fae8c982b811
3. added an IT to check how implementation of this new ReproducibleResourceTransformer can be run in old shade plugin by simply adding the interface (source copy or shade...) in https://github.com/apache/maven-shade-plugin/commit/4f83ae693f5c9f8022fc2b75c83b2bd632a1b6c8

> Breaking change to ResourceTransformer's API
> --------------------------------------------
>
>                 Key: MSHADE-363
>                 URL: https://issues.apache.org/jira/browse/MSHADE-363
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 3.2.3
>            Reporter: Andy Wilkinson
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: 3.2.4
>
>
> A Spring Boot user has [made us aware|https://github.com/spring-projects/spring-boot/issues/21128] of a [breaking change to the API of ResourceTransformer|https://github.com/apache/maven-shade-plugin/commit/0d7bfb53a5fd83eede7edfd5552db5fa561d6286#diff-f09094e2212bb4d1173a4e183635b958] in 3.2.3.
> Ideally, we don't want to require a specific version of the Shade plugin. While I think we may be able to support the new and old both variants of the method, it would be preferable if future 3.2.x releases are backwards compatible with 3.2.2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)