You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/04 19:55:57 UTC
Review Request 35082: Adjusted the NoopResourceEstimator to the new
slave semantics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35082/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Vinod Kone.
Repository: mesos
Description
-------
Adjusted the NoopResourceEstimator to the new slave semantics.
Diffs
-----
src/slave/resource_estimators/noop.cpp 772eb4e9bd987141b8ed9f5d7a681a7145b11a75
Diff: https://reviews.apache.org/r/35082/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 35082: Adjusted the NoopResourceEstimator to the
new slave semantics.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35082/#review86720
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On June 4, 2015, 10:55 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35082/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 10:55 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adjusted the NoopResourceEstimator to the new slave semantics.
>
>
> Diffs
> -----
>
> src/slave/resource_estimators/noop.cpp 772eb4e9bd987141b8ed9f5d7a681a7145b11a75
>
> Diff: https://reviews.apache.org/r/35082/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35082: Adjusted the NoopResourceEstimator to the
new slave semantics.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35082/#review86714
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 4, 2015, 5:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35082/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 5:55 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adjusted the NoopResourceEstimator to the new slave semantics.
>
>
> Diffs
> -----
>
> src/slave/resource_estimators/noop.cpp 772eb4e9bd987141b8ed9f5d7a681a7145b11a75
>
> Diff: https://reviews.apache.org/r/35082/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35082: Adjusted the NoopResourceEstimator to the
new slave semantics.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35082/#review86691
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35082]
All tests passed.
- Mesos ReviewBot
On June 4, 2015, 5:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35082/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 5:55 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adjusted the NoopResourceEstimator to the new slave semantics.
>
>
> Diffs
> -----
>
> src/slave/resource_estimators/noop.cpp 772eb4e9bd987141b8ed9f5d7a681a7145b11a75
>
> Diff: https://reviews.apache.org/r/35082/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>