[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1893: xtensa/esp32: Add ESP32 WiFi adapter and driver

[GitBox <gi...@apache.org>]

Ouss4 commented on pull request #1893:
URL: https://github.com/apache/incubator-nuttx/pull/1893#issuecomment-701984724


   > > I think that it is better to separate the firmware download from the build process and even store it on our git in a common firmware folder
   > > What for you think ?
   > 
   > I'm not sure it would be compatible with Apache license. Anyway, downloading external projects is very common in NuttX build, don't see why we can't do it here as well.
   
   Even though it's Apache licensed I think it will be treated as third-party.  That repository is meant to be general and can be used by other projects.  It makes sense to have it outside of our code base. 
   And as Matias said we already have the option of downloading external projects, part of this PR just adds that possibility to the arch/ folder.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org