You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/26 01:46:53 UTC
[GitHub] [skywalking-website] kezhenxu94 opened a new pull request #184: Polish the design to be more generic
kezhenxu94 opened a new pull request #184:
URL: https://github.com/apache/skywalking-website/pull/184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] kezhenxu94 merged pull request #184: Polish the design to be more generic
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #184:
URL: https://github.com/apache/skywalking-website/pull/184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #184: Polish the design to be more generic
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #184:
URL: https://github.com/apache/skywalking-website/pull/184#discussion_r548932977
##########
File path: content/blog/e2e-design/index.md
##########
@@ -174,9 +174,9 @@ trigger:
url: localhost:9090/users
verify:
- - query: service ls
+ - query: swctl service ls
expected: expected.services.yaml
- - query: endpoint ls --service="YnVzaW5lc3Mtem9uZTo6cHJvamVjdEM=.1"
+ - query: swctl endpoint ls --service="YnVzaW5lc3Mtem9uZTo6cHJvamVjdEM=.1"
Review comment:
Added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a change in pull request #184: Polish the design to be more generic
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #184:
URL: https://github.com/apache/skywalking-website/pull/184#discussion_r548931346
##########
File path: content/blog/e2e-design/index.md
##########
@@ -174,9 +174,9 @@ trigger:
url: localhost:9090/users
verify:
- - query: service ls
+ - query: swctl service ls
expected: expected.services.yaml
- - query: endpoint ls --service="YnVzaW5lc3Mtem9uZTo6cHJvamVjdEM=.1"
+ - query: swctl endpoint ls --service="YnVzaW5lc3Mtem9uZTo6cHJvamVjdEM=.1"
Review comment:
How do you determine the validator? Such as file format. Do you need to say we support YAML format only for now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org