You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/07 09:18:50 UTC
[GitHub] [incubator-dolphinscheduler] dailidong opened a new pull request
#1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
dailidong opened a new pull request #1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1752
change commons.lang3.StringUtils to common.utils.StringUtils
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1752#issuecomment-571504117
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=h1) Report
> Merging [#1752](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/0a39f1a4dd1910c9f86fac055add4c1a15ece1b8?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1752 +/- ##
==========================================
+ Coverage 20.22% 20.23% +<.01%
==========================================
Files 290 290
Lines 14082 14082
Branches 2374 2374
==========================================
+ Hits 2848 2849 +1
+ Misses 10909 10908 -1
Partials 325 325
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `57.14% <0%> (+14.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=footer). Last update [0a39f1a...a2555c1](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1752#issuecomment-571504117
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=h1) Report
> Merging [#1752](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/6c4debef391b82b36b148c295a7efb8a6c6f4b45?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `7.35%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1752 +/- ##
==========================================
- Coverage 20.27% 20.22% -0.06%
==========================================
Files 287 290 +3
Lines 14039 14082 +43
Branches 2369 2374 +5
==========================================
+ Hits 2847 2848 +1
- Misses 10867 10909 +42
Partials 325 325
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `68.42% <0%> (-4.48%)` | :arrow_down: |
| [...nscheduler/api/security/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `0% <0%> (ø)` | |
| [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `0% <0%> (ø)` | |
| [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `0% <0%> (ø)` | |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `73.26% <41.66%> (-0.32%)` | :arrow_down: |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=footer). Last update [6c4debe...7c1b37a](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1752:
fix change commons.lang3.StringUtils to common.utils.StringUtils
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1752#issuecomment-571504117
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`dev@8ae401e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1752 +/- ##
======================================
Coverage ? 20.22%
======================================
Files ? 290
Lines ? 14082
Branches ? 2374
======================================
Hits ? 2848
Misses ? 10910
Partials ? 324
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `0% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=footer). Last update [8ae401e...7c1b37a](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #1752:
fix change commons.lang3.StringUtils to common.utils.StringUtils
Posted by GitBox <gi...@apache.org>.
dailidong closed pull request #1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1752
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1752: fix change commons.lang3.StringUtils to common.utils.StringUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1752#issuecomment-571504117
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=h1) Report
> Merging [#1752](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/6c4debef391b82b36b148c295a7efb8a6c6f4b45?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `7.35%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1752 +/- ##
==========================================
- Coverage 20.27% 20.22% -0.06%
==========================================
Files 287 290 +3
Lines 14039 14082 +43
Branches 2369 2374 +5
==========================================
+ Hits 2847 2848 +1
- Misses 10867 10909 +42
Partials 325 325
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `68.42% <0%> (-4.48%)` | :arrow_down: |
| [...nscheduler/api/security/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `0% <0%> (ø)` | |
| [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `0% <0%> (ø)` | |
| [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `0% <0%> (ø)` | |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `73.26% <41.66%> (-0.32%)` | :arrow_down: |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=footer). Last update [6c4debe...7c1b37a](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1752?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services