You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by kelaban <gi...@git.apache.org> on 2016/07/08 19:44:24 UTC
[GitHub] lucene-solr pull request #50: SOLR-9280 - make nodeName a configurable param...
GitHub user kelaban opened a pull request:
https://github.com/apache/lucene-solr/pull/50
SOLR-9280 - make nodeName a configurable parameter in solr.xml
This patch makes live nodeName configurable via solr.xml by setting
```xml
<solr>
<solrcloud>
<str name="nodeName">${solr.nodeName:}</str>
</solrcloud>
</solr>
```
To test, I randomly set nodeName in `AbstractFullDistribZkTestBase` for complete coverage.
I've gotten all tests to pass both when ALWAYS using a random nodeName and with it being set randomly. However during one particular run I got a test failure for the following:
`ant test -Dtestcase=TestReqParamsAPI -Dtests.method=test -Dtests.seed=391BC4715DE8C2FE -Dtests.slow=true -Dtests.locale=pl-PL -Dtests.timezone=Asia/Chungking -Dtests.asserts=true -Dtests.file.encoding=UTF-8` but am unable to reproduce the issue in eclipse and at this time am not sure if its related
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kelaban/lucene-solr jira/master/SOLR-9280
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit b1de1f9ef97a5957747f7fcb9ac9e7ce4acfac84
Author: Keith Laban <kl...@bloomberg.net>
Date: 2016-06-30T15:12:16Z
SOLR-9280 - make nodeName a configurable parameter in solr.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #50: SOLR-9280 - make nodeName a configurable parameter in...
Posted by kelaban <gi...@git.apache.org>.
Github user kelaban commented on the issue:
https://github.com/apache/lucene-solr/pull/50
Updated so the patch now applies cleanly. I've been having trouble getting tests to pass on vanilla master branch, so I cannot tell if this is causing any to fail. I've spot checked a few tests with this patch and they worked fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: efbytesref 201405a1
Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot commented on the pull request:
https://github.com/apache/lucene-solr/pull/50#issuecomment-105225405
See LUCENE-5524 and LUCENE-5627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: efbytesref 201405a1
Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot closed the pull request at:
https://github.com/apache/lucene-solr/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #50: SOLR-9280 - make nodeName a configurable parameter in...
Posted by kelaban <gi...@git.apache.org>.
Github user kelaban commented on the issue:
https://github.com/apache/lucene-solr/pull/50
Randomly setting nodeName in tests which extend from `AbstractFullDistribZkTestBase` hits about 60 solr cloud tests. But there are also about 30 other cloud tests which use `MiniSolrCloudCluster` which will not get this randomness applied. To increase coverage we can add randomness into this class as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #50: SOLR-9280 - make nodeName a configurable parameter in...
Posted by kelaban <gi...@git.apache.org>.
Github user kelaban commented on the issue:
https://github.com/apache/lucene-solr/pull/50
Additionally work for SOLR-9281 is being done here (https://github.com/kelaban/lucene-solr/tree/jira/master/SOLR-9281) but will hold out on a PR as it relies on this branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org