You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by carynbear <gi...@git.apache.org> on 2016/08/01 22:18:02 UTC
[GitHub] cordova-lib pull request #474: CB-11653 copied findProjectRoot from cordova-...
GitHub user carynbear opened a pull request:
https://github.com/apache/cordova-lib/pull/474
CB-11653 copied findProjectRoot from cordova-lib; ToDo: migrate tests\u2026
\u2026 over
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/carynbear/cordova-lib CB-11653
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/474.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #474
----
commit a1b03129fcd235958f8bd3cbea39ed6b1b9b5892
Author: carynbear <ca...@berkeley.edu>
Date: 2016-07-20T23:16:49Z
CB-11653 copied findProjectRoot from cordova-lib; ToDo: migrate tests over
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/474
## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/474?src=pr) is 80.66% (diff: 100%)
> Merging [#474](https://codecov.io/gh/apache/cordova-lib/pull/474?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will not change coverage
```diff
@@ master #474 diff @@
==========================================
Files 68 68
Lines 5399 5399
Methods 856 856
Messages 0 0
Branches 1043 1043
==========================================
Hits 4355 4355
Misses 1044 1044
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [3ad0b50...197c5c8](https://codecov.io/gh/apache/cordova-lib/compare/3ad0b5029205171fbac4571d9272f4be9b7617cf...197c5c8d2aa723564b84c4ac9faf26a3043bac75?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/474
Can you create a issue to remove the duplicate code + tests from cordova-lib. That can be a separate PR after cordova-common has been released.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/474
@vladimir-kotikov any issues you see with us moving this from cordova-lib to cordova-common?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib; To...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/474
Two things:
1) migrate the tests over and add them to this pr
2) add the apache license header comment to the top. You will notice every other file has this. Apache requirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/474
@stevengill, @carynbear, no issues. Just curious where do you plan to use it outside of cordova-lib :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib; To...
Posted by carynbear <gi...@git.apache.org>.
Github user carynbear commented on the issue:
https://github.com/apache/cordova-lib/pull/474
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #474: CB-11653 copied findProjectRoot from cordova-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/474
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib
Posted by carynbear <gi...@git.apache.org>.
Github user carynbear commented on the issue:
https://github.com/apache/cordova-lib/pull/474
@stevengill https://issues.apache.org/jira/browse/CB-11654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib
Posted by carynbear <gi...@git.apache.org>.
Github user carynbear commented on the issue:
https://github.com/apache/cordova-lib/pull/474
I would like to use it in Phonegap, but also it seems like a useful method in general for dealing with Cordova projects. In the spirit of modularizing Cordova, it seems that Plugman would be a potential use case if it is broken out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/474
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/474
Ah, I see, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org