[GitHub] [doris] Kikyou1997 commented on a diff in pull request #17990: [tpch](nereids) q13 join order adjust

["Kikyou1997 (via GitHub)" <gi...@apache.org>]

Kikyou1997 commented on code in PR #17990:
URL: https://github.com/apache/doris/pull/17990#discussion_r1143226164


##########
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java:
##########
@@ -1143,4 +1145,8 @@ public List<SlotId> getOutputSlotIds() {
     public void setVConjunct(Set<Expr> exprs) {
         vconjunct = convertConjunctsToAndCompoundPredicate(new ArrayList<>(exprs));
     }
+
+    public void setCardinalityAfterFilter(long cardinalityAfterFilter) {

Review Comment:
   This method is redundant, use existed `setCardinality` instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org