[GitHub] [tvm] mehrdadh commented on a change in pull request #9007: [microTVM] Bump Arduino SDK versions in Vagrant VM

[GitBox <gi...@apache.org>]

mehrdadh commented on a change in pull request #9007:
URL: https://github.com/apache/tvm/pull/9007#discussion_r708393051



##########
File path: apps/microtvm/reference-vm/arduino/base-box/base_box_test.sh
##########
@@ -30,11 +30,11 @@ fi
 
 board=$1
 
-pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board}
+pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board} -s

Review comment:
       revert `-s`?

##########
File path: apps/microtvm/reference-vm/arduino/base-box/base_box_provision.sh
##########
@@ -45,7 +45,7 @@ ADAFRUIT_BOARDS_URL="https://adafruit.github.io/arduino-board-index/package_adaf
 ESP32_BOARDS_URL="https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_dev_index.json"

Review comment:
       can we fix version for other boards as well?

##########
File path: apps/microtvm/reference-vm/arduino/base-box/base_box_test.sh
##########
@@ -30,11 +30,11 @@ fi
 
 board=$1
 
-pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board}
+pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board} -s
 
 if [ $board == "nano33ble" ]; then
     # https://github.com/apache/tvm/issues/8730
     echo "NOTE: skipped test_arduino_rpc_server.py on $board -- known failure"
 else
-    pytest tests/micro/arduino/test_arduino_rpc_server.py --arduino-board=${board}
+    pytest tests/micro/arduino/test_arduino_rpc_server.py --arduino-board=${board} -s

Review comment:
       same here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org