You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/12/12 00:52:17 UTC

Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-3550
    https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description
-------

This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously, the containerizer test class only used to handle the driver interface.


Diffs
-----

  src/tests/containerizer.hpp 25b64dacca65aa0ac49a05a2fbaf526aa0761471 
  src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 

Diff: https://reviews.apache.org/r/41290/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

Posted by Anand Mazumdar <ma...@gmail.com>.

> On Feb. 3, 2016, 10:55 p.m., Vinod Kone wrote:
> > src/tests/containerizer.hpp, line 140
> > <https://reviews.apache.org/r/41290/diff/1/?file=1161079#file1161079line140>
> >
> >     s/v1callbacks/v1Callbacks/

Modified it to `v1Executors` now.


> On Feb. 3, 2016, 10:55 p.m., Vinod Kone wrote:
> > src/tests/containerizer.cpp, lines 104-108
> > <https://reviews.apache.org/r/41290/diff/1/?file=1161080#file1161080line104>
> >
> >     move this to #163

As per our offline discussion, we save the container to an existing map after we perform this check. If we move this to L163, we might have erroneously inserted a container without having an executor to launch it.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review117684
-----------------------------------------------------------


On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
>     https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously, the containerizer test class only used to handle the driver interface.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review117684
-----------------------------------------------------------




src/tests/containerizer.hpp (line 140)
<https://reviews.apache.org/r/41290/#comment178959>

    s/v1callbacks/v1Callbacks/



src/tests/containerizer.hpp (line 144)
<https://reviews.apache.org/r/41290/#comment178960>

    s/v1mesos/v1Mesos/



src/tests/containerizer.cpp (lines 104 - 108)
<https://reviews.apache.org/r/41290/#comment178976>

    move this to #163



src/tests/containerizer.cpp (line 116)
<https://reviews.apache.org/r/41290/#comment178970>

    kill this and just do a contains check below at #164.



src/tests/containerizer.cpp (line 157)
<https://reviews.apache.org/r/41290/#comment178961>

    not yours, but can you fix the indentation here?


- Vinod Kone


On Jan. 22, 2016, 8:32 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 8:32 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
>     https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously, the containerizer test class only used to handle the driver interface.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp 25b64dacca65aa0ac49a05a2fbaf526aa0761471 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review118342
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Feb. 9, 2016, 12:13 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 12:13 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
>     https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously, the containerizer test class only used to handle the driver interface.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 12:13 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Review comments from Vinod


Bugs: MESOS-4457
    https://issues.apache.org/jira/browse/MESOS-4457


Repository: mesos


Description
-------

This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously, the containerizer test class only used to handle the driver interface.


Diffs (updated)
-----

  src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
  src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 

Diff: https://reviews.apache.org/r/41290/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review118306
-----------------------------------------------------------




src/tests/containerizer.hpp (line 140)
<https://reviews.apache.org/r/41290/#comment179529>

    s/v1Mesos/v1Libraries/ ?



src/tests/containerizer.cpp (line 117)
<https://reviews.apache.org/r/41290/#comment179530>

    kill this.



src/tests/containerizer.cpp (line 164)
<https://reviews.apache.org/r/41290/#comment179531>

    ```
    if (executors.contains(...)) {
      Executor* executor = executors[executorInfo.executor_id()];
      ...
      ...
    } else {
      ...
      ...
    }
    ```


- Vinod Kone


On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
>     https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously, the containerizer test class only used to handle the driver interface.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 11:12 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Review comments


Bugs: MESOS-4457
    https://issues.apache.org/jira/browse/MESOS-4457


Repository: mesos


Description
-------

This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously, the containerizer test class only used to handle the driver interface.


Diffs (updated)
-----

  src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
  src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 

Diff: https://reviews.apache.org/r/41290/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/
-----------------------------------------------------------

(Updated Jan. 22, 2016, 8:32 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Updated JIRA link


Bugs: MESOS-4457
    https://issues.apache.org/jira/browse/MESOS-4457


Repository: mesos


Description
-------

This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously, the containerizer test class only used to handle the driver interface.


Diffs
-----

  src/tests/containerizer.hpp 25b64dacca65aa0ac49a05a2fbaf526aa0761471 
  src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 

Diff: https://reviews.apache.org/r/41290/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar