[GitHub] [incubator-doris] imay commented on a change in pull request #2394: Remove the readFields() method in Writable interface

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2394: Remove the readFields() method in Writable interface
URL: https://github.com/apache/incubator-doris/pull/2394#discussion_r354821046
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/journal/JournalEntity.java
 ##########
 @@ -109,63 +109,73 @@ public void write(DataOutput out) throws IOException {
         data.write(out);
     }
 
-    @Override
     public void readFields(DataInput in) throws IOException {
-        boolean needRead = true;
 
 Review comment:
   I think it's better to leave this value and add precondition check to make it true after switch clause. If some logic is forgetted to be changed, this can help us to avoid disaster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org