You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/01/08 12:57:48 UTC
[GitHub] couchdb-fauxton pull request: use require.js on the cli
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/599
use require.js on the cli
makes it composable, so we can have different targets
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton require-cli
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/599.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #599
----
commit ec3ef2045831ddde87153b06a1cee9228a894ad3
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-01-07T14:54:37Z
remove useless grunt defaults
the defaults are not used at all as all setting.json files
implement them, but make it harder for everyone to understand what
is happening.
additionally configuration should not be mixed into the
code as it turned out worthwile to don't mix config and code.
commit 42f2bfae215e918ceddb66d069472f8cb9f884c3
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-01-07T15:32:12Z
use require on the cli
makes it composable, so we can have different targets
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use require.js on the cli
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/599#issuecomment-170527902
merged as 5559ed2c2f26b5d7f8359f87146ff8d1bef603ae
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use require.js on the cli
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/599#issuecomment-170079276
Looks good to me. No problems building or running. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use require.js on the cli
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---