You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2025/01/07 09:42:17 UTC
[I] Confusing log messages about `POLARIS_SEQ` [polaris]
snazy opened a new issue, #621:
URL: https://github.com/apache/polaris/issues/621
### Describe the bug
The log messages
```
INFO [2025-01-07 10:14:25,982 - 1046 ] [main] [] o.a.p.e.p.i.e.PolarisSequenceUtil: Checking if the sequence POLARIS_SEQ exists
INFO [2025-01-07 10:14:25,990 - 1054 ] [main] [] o.a.p.e.p.i.e.PolarisSequenceUtil: POLARIS_SEQ does not exist, skipping NEXTVAL
```
are just confusing - the code mentions "legacy", but there is no "legacy" in Polaris.
### To Reproduce
_No response_
### Actual Behavior
_No response_
### Expected Behavior
_No response_
### Additional context
_No response_
### System information
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2585124252
Because there is no "legacy" in Polaris - and that message implies that there's something missing. TL;DR the message is not useful for users, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2597638211
The whole point is that a) the _logging_ is confusing and the "legacy" is not properly defined. But still, I cannot find any usage of `POLARIS_SEQ` even in the initial commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2597577485
I can see the Javadoc, but I don't see what you're confused by.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2596617602
> Also, what can or should a user do when he sees those messages?
Be aware of what entity in the backend is being used.
> There's no Polaris release yet, no?
I'm not sure I follow you here. The message doesn't refer to any version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2589506941
> What do you mean by “there is no legacy”?
There's no Polaris release yet, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2597610325
In this case it does. Again, there is no "POLARIS_SEQ legacy" in this code base, so the whole thing can and should go away. It is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2589508285
Also, what can or should a _user_ do when he sees those messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2580901557
Sorry, what are you confused by?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2597634276
No, in this case it actually doesn't. Maybe that's the source of confusion here?
Older "versions" of Polaris used this entity POLARIS_SEQ, but it isn't used by newer "versions". It is a sort of vestigial entity that may be used one-time to continue the sequence, and [legacy](https://en.wikipedia.org/wiki/Legacy_system) is used in that sense.
Is there another term that you think we should use which would be more clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2597649376
Yes -- if POLARIS_SEQ (removed [here](https://github.com/apache/polaris/commit/537eee6578afbea8dede47958edf0b6168326252#diff-86c8895dd16cf603f1de2aa49931368a075f7aafbe2bc4fca0bc7b8c2aa9be76L68)) was used in a release then I would prefer this comment to say something like:
```
If the generator `POLARIS_SEQ` used prior to Polaris X.Y is...
```
But since there isn't a version, "legacy" was the most descriptive term I could think of. The generator is legacy in that it may still be around in the metastore but should only be used in a one-off operation and otherwise is disused now.
Eventually I think we can even clean a lot of this up. We just needed this to make sure we didn't break any existing deployments using the old (legacy) metastore implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2597578161
Are you saying that you think "legacy" usually is an identifier used to refer to a particular version of software? It is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard closed issue #621: Confusing log messages about `POLARIS_SEQ`
URL: https://github.com/apache/polaris/issues/621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2585125739
What do you mean by “there is no legacy”?
On Fri, Jan 10, 2025 at 10:56 PM Robert Stupp ***@***.***>
wrote:
> Because there is no "legacy" in Polaris - and that message implies that
> there's something missing. TL;DR the message is not useful for users, right?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/polaris/issues/621#issuecomment-2585124252>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFRE3SHLL4YI5LERB7RBGUT2KC6DJAVCNFSM6AAAAABUXKPDX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVGEZDIMRVGI>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2597572304
> Be aware of what entity in the backend is being used.
@eric-maynard the term "legacy" is used in the Javadoc: "If the legacy `POLARIS_SEQ` generator is available it will be used then cleaned up. In all other cases the `POLARIS_SEQUENCE` table is used directly.". No previous version (there is none released, right?) of the Apache Polaris code base used that identifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Confusing log messages about `POLARIS_SEQ` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on issue #621:
URL: https://github.com/apache/polaris/issues/621#issuecomment-2597662693
TBH: since there is no Polaris release yet, there is nothing to care about. I'll start a dev-ML discussion about this.
TL;DR the whole POLARIS_SEQ stuff can and should go away, especially the user-nag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org