You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/31 05:09:58 UTC

[GitHub] [dolphinscheduler] Amy0104 commented on a diff in pull request #12538: [Improvement-12536][k8s] Support the command for the container in k8s task plugin

Amy0104 commented on code in PR #12538:
URL: https://github.com/apache/dolphinscheduler/pull/12538#discussion_r1009034066


##########
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-k8s.ts:
##########
@@ -59,6 +59,18 @@ export function useK8s(model: { [field: string]: any }): IJsonItem[] {
         message: t('project.node.min_memory_tips')
       }
     },
+    {
+      type: 'input',
+      field: 'command',
+      name: t('project.node.command'),
+      props: {
+        placeholder: t('project.node.command_tips')
+      },
+      validate: {
+        trigger: ['input', 'blur'],
+        message: t('project.node.command_tips')
+      }

Review Comment:
   what is this to validate? required?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org