You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/01/18 11:39:33 UTC

Review Request 42247: Made sure the container launcher terminated before we leave the test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/
-----------------------------------------------------------

Review request for mesos and Till Toenshoff.


Bugs: MESOS-4329
    https://issues.apache.org/jira/browse/MESOS-4329


Repository: mesos


Description
-------

Waiting for the launch result is not enough as it is unrelated to
whether the launched container has terminated. If we do not wait for
that the global teardown might find it still running and fail the tests
(this can happen if we e.g., execute this test in isolation).


Diffs
-----

  src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa 

Diff: https://reviews.apache.org/r/42247/diff/


Testing
-------

make check (OS X 10.10.5)


Thanks,

Benjamin Bannier