You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/05/21 18:59:32 UTC
Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8940
https://issues.apache.org/jira/browse/MESOS-8940
Repository: mesos
Description
-------
Added per-framework metrics for types of resources contained in offers.
Diffs
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
Diff: https://reviews.apache.org/r/67235/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review203554
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66882, 66819, 66820, 66822, 66823, 66845, 66825, 66846, 66847, 66841, 66842, 66843, 67147, 66844, 66855, 66861, 66856, 66870, 66874, 67043, 66883, 67187, 67235]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 21, 2018, 7:03 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 7:03 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8940
> https://issues.apache.org/jira/browse/MESOS-8940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for types of resources contained in offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
> src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
>
>
> Diff: https://reviews.apache.org/r/67235/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review203522
-----------------------------------------------------------
PASS: Mesos patch 67235 was successfully built and tested.
Reviews applied: `['66882', '66819', '66820', '66822', '66823', '66845', '66825', '66846', '66847', '66841', '66842', '66843', '67147', '66844', '66855', '66861', '66856', '66870', '66874', '67043', '66883', '67187', '67235']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235
- Mesos Reviewbot Windows
On May 21, 2018, 7:03 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 7:03 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8940
> https://issues.apache.org/jira/browse/MESOS-8940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for types of resources contained in offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
> src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
>
>
> Diff: https://reviews.apache.org/r/67235/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review203647
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66882, 66819, 66820, 66822, 66823, 66845, 66825, 66846, 66847, 66841, 66842, 66843, 67147, 66844, 66855, 66861, 66856, 66870, 66874, 67043, 66883, 67187, 67235]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 23, 2018, 6:47 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
>
> (Updated May 23, 2018, 6:47 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8940
> https://issues.apache.org/jira/browse/MESOS-8940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for types of resources contained in offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
> src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
>
>
> Diff: https://reviews.apache.org/r/67235/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review203768
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66882, 66819, 66820, 66822, 66823, 66845, 66825, 66846, 66847, 66841, 66842, 66843, 67147, 66844, 66855, 66861, 66856, 66870, 66874, 67043, 66883, 67187, 67235]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 24, 2018, 12:14 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 12:14 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8940
> https://issues.apache.org/jira/browse/MESOS-8940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for types of resources contained in offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
> src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
>
>
> Diff: https://reviews.apache.org/r/67235/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/
-----------------------------------------------------------
(Updated July 18, 2018, 1:46 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8940
https://issues.apache.org/jira/browse/MESOS-8940
Repository: mesos
Description
-------
Added per-framework metrics for types of resources contained in offers.
Diffs
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
Diff: https://reviews.apache.org/r/67235/diff/5/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review205698
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66882', '66819', '66820', '67808', '67809', '67812', '67813', '67814', '66841', '66842', '66843', '67147', '66844', '66855', '66861', '66856', '66870', '66883', '67187', '67235']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235/logs/mesos-tests-stdout.log):
```
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (801 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (599 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[ OK ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1325 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (802 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (802 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1006 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (597 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[ OK ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5165 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4956 ms)
[----------] 24 tests from DockerContainerizerTest (90217 ms total)
[----------] 1 test from HungDockerTest
[ RUN ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull
d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000905693BDB0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000905693C010.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @00000265933CF4C8.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000002659450F360.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @00000265945C6FB0.
ERROR: 5 leaked mock objects found at program exit.
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235/logs/mesos-tests-stderr.log):
```
I0703 22:51:45.960681 9388 authenticatee.cpp:299] Authentication success
I0703 22:51:45.961689 8204 master.cpp:9830] Successfully authenticated principal 'test-principal' at scheduler-0ef579da-198f-407a-b859-3ba49ca2031c@192.10.1.6:56346
I0703 22:51:45.961689 8552 sched.cpp:501] Successfully authenticated with master master@192.10.1.6:56346
I0703 22:51:45.962689 9388 master.cpp:2941] Received SUBSCRIBE call for framework 'default' at scheduler-0ef579da-198f-407a-b859-3ba49ca2031c@192.10.1.6:56346
I0703 22:51:45.962689 9388 master.cpp:2242] Authorizing framework principal 'test-principal' to receive offers for roles '{ * }'
I0703 22:51:45.963690 8224 master.cpp:3022] Subscribing framework default with checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 22:51:45.975672 8224 master.cpp:10021] Adding framework 993d0452-bfa9-45ad-a897-56720c36c7ed-0000 (default) at scheduler-0ef579da-198f-407a-b859-3ba49ca2031c@192.10.1.6:56346 with roles { } suppressed
I0703 22:51:45.976670 5668 sched.cpp:749] Framework registered with 993d0452-bfa9-45ad-a897-56720c36c7ed-0000
I0703 22:51:45.978691 8204 hierarchical.cpp:306] Added framework 993d0452-bfa9-45ad-a897-56720c36c7ed-0000
E0703 22:51:46.063894 8380 slave.cpp:7289] EXIT with status 1: Failed to perform recovery: Collect failed: Failed to run 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat -H npipe:////./pipe/docker_engine ps -a': exited with status 1; stderr=''C:\Program' is not recognized as an internal or external command,
operable program or batch file.
'
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` flag to a more permissive value.
To restart this agent with a new agent id instead, do as follows:
rm -f C:\Users\jenkins\AppData\Local\Temp\sDOVv4\meta\slaves\latest
This ensures that the agent does not recover old live executors.
If you use the Docker containerizer and think that the Docker
daemon state is broken, you can try to clear it. But be careful:
these commands will erase all containers and images from this host,
not just those started by Mesos!
docker kill $(docker ps -q)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)
Finally, restart the agent.
```
- Mesos Reviewbot Windows
On July 3, 2018, 9:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 9:41 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8940
> https://issues.apache.org/jira/browse/MESOS-8940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for types of resources contained in offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
>
>
> Diff: https://reviews.apache.org/r/67235/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/
-----------------------------------------------------------
(Updated July 3, 2018, 9:41 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8940
https://issues.apache.org/jira/browse/MESOS-8940
Repository: mesos
Description
-------
Added per-framework metrics for types of resources contained in offers.
Diffs (updated)
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
Diff: https://reviews.apache.org/r/67235/diff/5/
Changes: https://reviews.apache.org/r/67235/diff/4-5/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review203724
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66882', '66819', '66820', '66822', '66823', '66845', '66825', '66846', '66847', '66841', '66842', '66843', '67147', '66844', '66855', '66861', '66856', '66870', '66874', '67043', '66883', '67187', '67235']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (119 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1020 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (36 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (40 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (78 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (753 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (777 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (733 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (758 ms total)
[----------] Global test environment tear-down
[==========] 981 tests from 95 test cases ran. (442695 ms total)
[ PASSED ] 980 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235/logs/mesos-tests-stderr.log):
```
I0524 01:07:36.243073 12688 exec.cpp:236] Executor registered on agent af4c0c0f-2035-4c29-a19f-8501b28595d4-S0
I0524 01:07:36.247076 7304 executor.cpp:178] Received SUBSCRIBED event
I0524 01:07:36.251077 7304 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0524 01:07:36.252076 7304 executor.cpp:178] Received LAUNCH event
I0524 01:07:36.256086 7304 executor.cpp:665] Starting task ad106be2-4431-4931-96fc-7963fcb16d23
I0524 01:07:36.334095 7304 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0524 01:07:36.351090 7304 executor.cpp:678] Forked command at 20204
I0524 01:07:36.378093 6588 exec.cpp:445] Executor asked to shutdown
I0524 01:07:36.379086 18944 executor.cpp:178] Received SHUTDOWN event
I0524 01:07:36.379086 18944 executor.cpp:781] Shutting down
I0524 01:07:36.379086 18944 executor.cpp:894] Sending SIGTERM to process tree at pid 20035-4c29-a19f-8501b28595d4-0000
I0524 01:07:36.376090 20572 slave.cpp:3935] Shutting down framework af4c0c0f-2035-4c29-a19f-8501b28595d4-0000
I0524 01:07:36.376090 20496 master.cpp:10886] Updating the state of task ad106be2-4431-4931-96fc-7963fcb16d23 of framework af4c0c0f-2035-4c29-a19f-8501b28595d4-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0524 01:07:36.377100 20572 slave.cpp:6656] Shutting down executor 'ad106be2-4431-4931-96fc-7963fcb16d23' of framework af4c0c0f-2035-4c29-a19f-8501b28595d4-0000 at executor(1)@192.10.1.6:55181
I0524 01:07:36.378093 20572 slave.cpp:929] Agent terminating
W0524 01:07:36.378093 20572 slave.cpp:3931] Ignoring shutdown framework af4c0c0f-2035-4c29-a19f-8501b28595d4-0000 because it is terminating
I0524 01:07:36.380089 20496 master.cpp:10975] Removing task ad106be2-4431-4931-96fc-7963fcb16d23 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework af4c0c0f-2035-4c29-a19f-8501b28595d4-0000 on agent af4c0c0f-2035-4c29-a19f-8501b28595d4-S0 at slave(448)@192.10.1.6:55160 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 01:07:36.383090 15248 containerizer.cpp:2401] Destroying container f3a42156-04a9-42d1-9280-097667eecce1 in RUNNING state
I0524 01:07:36.383090 15248 containerizer.cpp:3015] Transitioning the state of container f3a42156-04a9-42d1-9280-097667eecce1 from RUNNING to DESTROYING
I0524 01:07:36.383090 20496 master.cpp:1301] Agent af4c0c0f-2035-4c29-a19f-8501b28595d4-S0 at slave(448)@192.10.1.6:55160 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0524 01:07:36.383090 20496 master.cpp:3317] Disconnecting agent af4c0c0f-2035-4c29-a19f-8501b28595d4-S0 at slave(448)@192.10.1.6:55160 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 01:07:36.383090 20496 master.cpp:3336] Deactivating agent af4c0c0f-2035-4c29-a19f-8501b28595d4-S0 at slave(448)@192.10.1.6:55160 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 01:07:36.384095 19260 hierarchical.cpp:357] Removed framework af4c0c0f-2035-4c29-a19f-8501b28595d4-0000
I0524 01:07:36.384095 15248 launcher.cpp:156] Asked to destroy container f3a42156-04a9-42d1-9280-097667eecce1
I0524 01:07:36.384095 20096 hierarchical.cpp:790] Agent af4c0c0f-2035-4c29-a19f-8501b28595d4-S0 deactivated
I0524 01:07:36.454092 19868 containerizer.cpp:2854] Container f3a42156-04a9-42d1-9280-097667eecce1 has exited
I0524 01:07:36.484095 7160 master.cpp:1143] Master terminating
I0524 01:07:36.485091 20096 hierarchical.cpp:632] Removed agent af4c0c0f-2035-4c29-a19f-8501b28595d4-S0
I0524 01:07:36.895100 16496 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On May 24, 2018, 12:14 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 12:14 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8940
> https://issues.apache.org/jira/browse/MESOS-8940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for types of resources contained in offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
> src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
>
>
> Diff: https://reviews.apache.org/r/67235/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/
-----------------------------------------------------------
(Updated May 24, 2018, 12:14 a.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8940
https://issues.apache.org/jira/browse/MESOS-8940
Repository: mesos
Description
-------
Added per-framework metrics for types of resources contained in offers.
Diffs (updated)
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
Diff: https://reviews.apache.org/r/67235/diff/4/
Changes: https://reviews.apache.org/r/67235/diff/3-4/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review203702
-----------------------------------------------------------
src/master/metrics.cpp
Lines 885 (patched)
<https://reviews.apache.org/r/67235/#comment285980>
If we increment for each resource in the offer, we'll end up incrementing multiple times when an offer contains multiple disk resources, for example.
- Greg Mann
On May 22, 2018, 10:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 10:47 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8940
> https://issues.apache.org/jira/browse/MESOS-8940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for types of resources contained in offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
> src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
>
>
> Diff: https://reviews.apache.org/r/67235/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review203623
-----------------------------------------------------------
PASS: Mesos patch 67235 was successfully built and tested.
Reviews applied: `['66882', '66819', '66820', '66822', '66823', '66845', '66825', '66846', '66847', '66841', '66842', '66843', '67147', '66844', '66855', '66861', '66856', '66870', '66874', '67043', '66883', '67187', '67235']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235
- Mesos Reviewbot Windows
On May 22, 2018, 3:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 3:47 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8940
> https://issues.apache.org/jira/browse/MESOS-8940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for types of resources contained in offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
> src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
>
>
> Diff: https://reviews.apache.org/r/67235/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/
-----------------------------------------------------------
(Updated May 22, 2018, 10:47 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8940
https://issues.apache.org/jira/browse/MESOS-8940
Repository: mesos
Description
-------
Added per-framework metrics for types of resources contained in offers.
Diffs (updated)
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
Diff: https://reviews.apache.org/r/67235/diff/3/
Changes: https://reviews.apache.org/r/67235/diff/2-3/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/
-----------------------------------------------------------
(Updated May 21, 2018, 7:03 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8940
https://issues.apache.org/jira/browse/MESOS-8940
Repository: mesos
Description
-------
Added per-framework metrics for types of resources contained in offers.
Diffs (updated)
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31
Diff: https://reviews.apache.org/r/67235/diff/2/
Changes: https://reviews.apache.org/r/67235/diff/1-2/
Testing
-------
Thanks,
Greg Mann