You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2025/07/11 15:29:52 UTC
[PR] Perf: Optimize performance of ByteViewGroupValueBuilder on batches with inlined views [datafusion]
zhuqi-lucas opened a new pull request, #16751:
URL: https://github.com/apache/datafusion/pull/16751
## Which issue does this PR close?
Optimize following cases, and add more fast path.
do_append_val_inner
do_equal_to_inner
This is wasteful if there is no data buffer, in which case we can improve the performance.
- Closes [#16330](https://github.com/apache/datafusion/issues/16330)
## Rationale for this change
Optimize following cases, and add more fast path.
do_append_val_inner
do_equal_to_inner
## What changes are included in this PR?
Optimize following cases, and add more fast path.
do_append_val_inner
do_equal_to_inner
## Are these changes tested?
Yes
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Perf: Optimize performance of ByteViewGroupValueBuilder on batches with inlined views [datafusion]
Posted by "Rachelint (via GitHub)" <gi...@apache.org>.
Rachelint commented on PR #16751:
URL: https://github.com/apache/datafusion/pull/16751#issuecomment-3064694448
> Thank you @Rachelint , it seems no performance improvement for clickbench from my local Mac benchmark, i need to investigate further.
Yes... I did a simple try only in append path before, and also found no obvious improvement... We indeed need further investigation maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Perf: Optimize performance of ByteViewGroupValueBuilder on batches with inlined views [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16751:
URL: https://github.com/apache/datafusion/pull/16751#issuecomment-3277106039
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Perf: Optimize performance of ByteViewGroupValueBuilder on batches with inlined views [datafusion]
Posted by "Rachelint (via GitHub)" <gi...@apache.org>.
Rachelint commented on PR #16751:
URL: https://github.com/apache/datafusion/pull/16751#issuecomment-3064683673
Thanks @zhuqi-lucas ! How about the benchmark result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Perf: Optimize performance of ByteViewGroupValueBuilder on batches with inlined views [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #16751: Perf: Optimize performance of ByteViewGroupValueBuilder on batches with inlined views
URL: https://github.com/apache/datafusion/pull/16751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Perf: Optimize performance of ByteViewGroupValueBuilder on batches with inlined views [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #16751:
URL: https://github.com/apache/datafusion/pull/16751#issuecomment-3064694991
> > Thank you @Rachelint , it seems no performance improvement for clickbench from my local Mac benchmark, i need to investigate further.
>
> Yes... I made a simple try only in append path before, and also found no obvious improvement... We indeed need further investigation maybe
I agree, mark it a draft now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Perf: Optimize performance of ByteViewGroupValueBuilder on batches with inlined views [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #16751:
URL: https://github.com/apache/datafusion/pull/16751#issuecomment-3064692416
Thank you @Rachelint , it seems no performance improvement for clickbench from my Mac benchmark, i need to investigate further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org