You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/01 07:32:03 UTC
[GitHub] [flink] autophagy opened a new pull request #19317: [FLINK-26772][runtime] Add flag to prevent job submission in Dispatcher if shutting down
autophagy opened a new pull request #19317:
URL: https://github.com/apache/flink/pull/19317
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## Brief change log
- *Added a flag to prevent job submission in the Dispatcher if a shutdown has been triggered*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19317: [FLINK-26772][runtime] Add flag to prevent job submission in Dispatcher if shutting down
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19317:
URL: https://github.com/apache/flink/pull/19317#issuecomment-1085537398
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f058a2efe72977c3173aab521440305be2aeefb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f058a2efe72977c3173aab521440305be2aeefb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f058a2efe72977c3173aab521440305be2aeefb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19317: [FLINK-26772][runtime] Add flag to prevent job submission in Dispatcher if shutting down
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19317:
URL: https://github.com/apache/flink/pull/19317#issuecomment-1085537398
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f058a2efe72977c3173aab521440305be2aeefb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34081",
"triggerID" : "5f058a2efe72977c3173aab521440305be2aeefb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f058a2efe72977c3173aab521440305be2aeefb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #19317: [FLINK-26772][runtime] Add flag to prevent job submission in Dispatcher if shutting down
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #19317:
URL: https://github.com/apache/flink/pull/19317#discussion_r840403801
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -167,6 +168,8 @@
private final ResourceCleaner localResourceCleaner;
private final ResourceCleaner globalResourceCleaner;
+ private final AtomicBoolean shutDown = new AtomicBoolean(false);
Review comment:
```suggestion
private final volatile boolean isShutdown = false;
```
For primitive values like boolean, you could use the `volatile` keyword to mark a member for multi-threaded access. This will prevent the data to be loaded into the Threads stack. Threads will, instead, look it up directly on the heap. This is sufficient for primitive values like boolean, because they are written in a atomic fashion.
An example of such a usage can be found in [ClosingFSDataOutputStream.closed](https://github.com/apache/flink/blob/e0b4cbb5694d9c58f871b79e52da250a2f08cd2a/flink-core/src/main/java/org/apache/flink/core/fs/ClosingFSDataOutputStream.java#L39)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] autophagy commented on a change in pull request #19317: [FLINK-26772][runtime] Add flag to prevent job submission in Dispatcher if shutting down
Posted by GitBox <gi...@apache.org>.
autophagy commented on a change in pull request #19317:
URL: https://github.com/apache/flink/pull/19317#discussion_r840434314
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -167,6 +168,8 @@
private final ResourceCleaner localResourceCleaner;
private final ResourceCleaner globalResourceCleaner;
+ private final AtomicBoolean shutDown = new AtomicBoolean(false);
Review comment:
Aha, right. I saw uses of `volatile boolean` and `AtomicBoolean` throughout, thanks for clarifying the usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19317: [FLINK-26772][runtime] Add flag to prevent job submission in Dispatcher if shutting down
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19317:
URL: https://github.com/apache/flink/pull/19317#issuecomment-1085537398
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f058a2efe72977c3173aab521440305be2aeefb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34081",
"triggerID" : "5f058a2efe72977c3173aab521440305be2aeefb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f058a2efe72977c3173aab521440305be2aeefb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org