You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by se...@apache.org on 2017/02/27 16:30:03 UTC

cxf git commit: Fix to the oidc registration service

Repository: cxf
Updated Branches:
  refs/heads/master f6b153c1c -> 52d774702


Fix to the oidc registration service


Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/52d77470
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/52d77470
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/52d77470

Branch: refs/heads/master
Commit: 52d77470228a3560f464003c68b30ffe8f1e8b9c
Parents: f6b153c
Author: Sergey Beryozkin <sb...@gmail.com>
Authored: Mon Feb 27 16:29:43 2017 +0000
Committer: Sergey Beryozkin <sb...@gmail.com>
Committed: Mon Feb 27 16:29:43 2017 +0000

----------------------------------------------------------------------
 .../oidc/idp/OidcDynamicRegistrationService.java       | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf/blob/52d77470/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java
----------------------------------------------------------------------
diff --git a/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java b/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java
index 39cf8b2..cffcfc2 100644
--- a/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java
+++ b/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java
@@ -49,7 +49,12 @@ public class OidcDynamicRegistrationService extends DynamicRegistrationService {
 
     @Override
     protected ClientRegistrationResponse fromClientToRegistrationResponse(Client client) {
-        ClientRegistrationResponse resp = super.fromClientToRegistrationResponse(client);
+        return super.fromClientToRegistrationResponse(client);
+    }
+
+    @Override
+    protected ClientRegistration fromClientToClientRegistration(Client client) {
+        ClientRegistration resp = super.fromClientToClientRegistration(client);
         String logoutUris = client.getProperties().get(RP_INITIATED_LOGOUT_URIS);
         if (logoutUris != null) {
             List<String> list = new LinkedList<String>();
@@ -61,12 +66,6 @@ public class OidcDynamicRegistrationService extends DynamicRegistrationService {
         return resp;
     }
 
-    @Override
-    protected ClientRegistration fromClientToClientRegistration(Client client) {
-        //TODO: check OIDC specific properties in Client extra properties
-        return super.fromClientToClientRegistration(client);
-    }
-
     protected int getClientSecretSizeInBytes(ClientRegistration request) {
 
         // TODO: may need to be 384/8 or 512/8 if not a default HS256 but HS384 or HS512